From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755055AbbBBTsU (ORCPT ); Mon, 2 Feb 2015 14:48:20 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:39975 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754607AbbBBTsS (ORCPT ); Mon, 2 Feb 2015 14:48:18 -0500 Message-ID: <54CFD481.7050108@codeaurora.org> Date: Mon, 02 Feb 2015 11:48:17 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Robert Jarzmik , Mike Turquette CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: pxa: fix pxa27x_clocks_init scope References: <1422743840-32689-1-git-send-email-robert.jarzmik@free.fr> In-Reply-To: <1422743840-32689-1-git-send-email-robert.jarzmik@free.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/15 14:37, Robert Jarzmik wrote: > As pxa27x_clocks_init() is called from early boot stage, it has to be > reachable from pxa architecture code, as are pxa25x_clocks_init() and > pxa2xx_clock_init(). > > Remove the static declaration, which was introduced before the order > issue between clocks and the timer was discovered (ie. the clocks have > to be available before the timer, all of this before initcalls are > called). > > Signed-off-by: Robert Jarzmik Is this supposed to go through the clk tree? $ git grep pxa27x_clocks_init drivers/clk/pxa/clk-pxa27x.c:static int __init pxa27x_clocks_init(void) drivers/clk/pxa/clk-pxa27x.c:postcore_initcall(pxa27x_clocks_init); drivers/clk/pxa/clk-pxa27x.c: pxa27x_clocks_init(); Where's the early boot stage architecture calling code? > --- > drivers/clk/pxa/clk-pxa27x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/pxa/clk-pxa27x.c b/drivers/clk/pxa/clk-pxa27x.c > index 5f9b54b..7f8f344 100644 > --- a/drivers/clk/pxa/clk-pxa27x.c > +++ b/drivers/clk/pxa/clk-pxa27x.c > @@ -362,7 +362,7 @@ static void __init pxa27x_base_clocks_init(void) > clk_register_clk_pxa27x_lcd_base(); > } > > -static int __init pxa27x_clocks_init(void) > +int __init pxa27x_clocks_init(void) > { > pxa27x_base_clocks_init(); > return clk_pxa_cken_init(pxa27x_clocks, ARRAY_SIZE(pxa27x_clocks)); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project