From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755608AbbBBXzM (ORCPT ); Mon, 2 Feb 2015 18:55:12 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:37210 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754569AbbBBXzE (ORCPT ); Mon, 2 Feb 2015 18:55:04 -0500 X-AuditID: cbfee68d-f79296d000004278-54-54d00e4c22a6 Message-id: <54D00E4B.9040303@samsung.com> Date: Tue, 03 Feb 2015 08:54:51 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Sylwester Nawrocki Cc: cw00.choi@samsung.com, Chanwoo Choi , Tomasz Figa , Mike Turquette , Kukjin Kim , "pankaj.dubey@samsung.com" , sangbae90.lee@samsung.com, "inki.dae@samsung.com" , "chanho61.park@samsung.com" , Seung-Woo Kim , linux-samsung-soc , linux-kernel Subject: Re: [PATCH v4 01/13] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains References: <1422882074-19758-1-git-send-email-cw00.choi@samsung.com> <1422882074-19758-2-git-send-email-cw00.choi@samsung.com> <54CF81DE.3010902@samsung.com> <54CF84D8.7070208@samsung.com> <54CF8C75.7000104@samsung.com> <54CFA4ED.3050902@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsWyRsSkRNeH70KIwY2N7BaX92tbXP/ynNXi 2VFti0n3J7BY9D9+zWxxedccNosZ5/cxWTydcJHNYtHWL+wWh9+0s1oc/3SQxWLG5JdsFqt2 /WF04PXYOesuu8emVZ1sHneu7WHz6NuyitHj8ya5ANYoLpuU1JzMstQifbsErozf/VdYCl6L VLQeeczewPiKv4uRg0NCwETiwwKVLkZOIFNM4sK99WxdjFwcQgJLGSVmtF5lgkiYSMw4dJcJ IjGdUeLipz52COc1o8TS/sfMIFW8AloSHXOus4PYLAKqElPWtoLZbEDx/S9usIHYogJhEiun X2GBqBeU+DH5HpgtIqAvsWTVRbDVzAL/mCUOPb7CCJIQFsiWOPB9FtS2icwS7RvbwG7iFAiW eLZkNiuIzSygLjFp3iJmCFteYvOat8wQd/9kl3gwXwviIgGJb5MPsUD8LCux6QBUiaTEwRU3 WCYwis1CctMsJFNnIZm6gJF5FaNoakFyQXFSepGhXnFibnFpXrpecn7uJkZgxJ7+96x3B+Pt A9aHGAU4GJV4eC3enwsRYk0sK67MPcRoCnTFRGYp0eR8YFrIK4k3NDYzsjA1MTU2Mrc0UxLn VZT6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qBcfmNKwvjlpt82fNv3flc9ydt1446b7GR 3svgILTpy1tuu6b9d14Lsc6sXhi7une/RKO28Jtu7Y8tLn4Wuc9tTvuu1fxUn/jt7P2DYve7 bqct2v+l/eVf7TrWT1+6bwY/ePkt/6OriGDVWeszKhN3rmA1qLmnMElm7/7b/f0GLMlPuB0S 7ITKWpRYijMSDbWYi4oTAf3rBCDTAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42I5/e+xoK4334UQg+uTbSwu79e2uP7lOavF s6PaFpPuT2Cx6H/8mtni8q45bBYzzu9jsng64SKbxaKtX9gtDr9pZ7U4/ukgi8WMyS/ZLFbt +sPowOuxc9Zddo9NqzrZPO5c28Pm0bdlFaPH501yAaxRDYw2GamJKalFCql5yfkpmXnptkre wfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUA3KimUJeaUAoUCEouLlfTtME0IDXHTtYBp jND1DQmC6zEyQAMJaxgzfvdfYSl4LVLReuQxewPjK/4uRk4OCQETiRmH7jJB2GISF+6tZ+ti 5OIQEpjOKHHxUx87hPOaUWJp/2NmkCpeAS2JjjnX2UFsFgFViSlrW8FsNqD4/hc32EBsUYEw iZXTr7BA1AtK/Jh8D8wWEdCXWLLqItgGZoF/zBKHHl9hBEkIC2RLHPg+C2rbRGaJ9o1tYDdx CgRLPFsymxXEZhZQl5g0bxEzhC0vsXnNW+YJjAKzkCyZhaRsFpKyBYzMqxhFUwuSC4qT0nMN 9YoTc4tL89L1kvNzNzGCU8IzqR2MKxssDjEKcDAq8fBavD8XIsSaWFZcmXuIUYKDWUmE1+/M +RAh3pTEyqrUovz4otKc1OJDjKbAMJjILCWanA9MV3kl8YbGJmZGlkbmhhZGxuZK4rxK9m0h QgLpiSWp2ampBalFMH1MHJxSDYy8Kjff+07+e2hriZS41ekEz9Nn375xM/iky3L099xtRrtX rOT2KGS2mi5c6C30maX2UnDJsbpcF2b2ghX+Ic+mMXNOO9oWcvtlztY1y2ZO5L5+vqDlhkr2 3Ibfs3Satsxc8m2W6+7pO00FWSceV9T/4n5GStXr5SG3j6FGO7ZcPPNb58Lu2S45SizFGYmG WsxFxYkA5VC2zR8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sylwester, On 02/03/2015 01:44 AM, Chanwoo Choi wrote: > Hi Sylwester, > > On Tue, Feb 3, 2015 at 1:25 AM, Sylwester Nawrocki > wrote: >> Hi Chanwoo, >> >> On 02/02/15 16:51, Chanwoo Choi wrote: >>> On Mon, Feb 2, 2015 at 11:40 PM, Sylwester Nawrocki >>> wrote: >>>>> On 02/02/15 15:08, Chanwoo Choi wrote: >>>>> >>>>>>> OK, I'll add more following information: >>>>>>> I'll send only patch1 with following information. >>>>>>> >>>>>>> + - clocks: list of clock identifiers which are fed as the input to >>>>>>> + the given clock controller. Please refer the next section to >>>>>>> + find the input clocks for a given controller. >>>>>>> + - clock-names: list of names of clocks which are fed as the input >>>>>>> + to the given clock controller. >>>>>>> + >>>>> >>>>> Perhaps: >>>>> >>>>> + - clocks: list of the clock controller input clock identifiers, >>>>> from common clock bindings. Please refer the next section >>>>> to find the input clocks for a given controller. >>>>> >>>>> +- clock-names: list of the clock controller input clock names, >>>>> as described in clock-bindings.txt. >>>>> >>>>> ? >>>>> It's fine to resend just updated first patch from each series. >>> OK, >>> I'll modify the comment of 'clocks' and 'clock-names' and send only first patch. >>> >>> I have a question. Do you prefer to add the list of input clocks for >>> each clock domain as following? >>> Or it is not necessary? >>> >>> + Input clocks for top clock controller: >>> + - oscclk >>> + - sclk_mphy_pll >>> + - sclk_mfc_pll >>> + - sclk_bus_pll >> >> We are supposed to document all required input clocks somehow, I would >> keep the list in such form. The (example) cmu nodes are also a good >> documentation IMHO, they also show clearly which cmu (block) given clock >> is sourced from. > > I agree that the binding document have to contain all required information. > The binding document of exynos5433-clock will contain all input clocks for > each clock domain. Also, I'll modify the description of 'clocks'/'clock-names' > according to your comment and then I'll re-send only updated first > patch for document. I send only updated first patch[1] and will post new patch-set(v3) for remainings 9 patches with input clock information. [1] https://lkml.org/lkml/2015/2/2/761 - [PATCH v6] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains Thanks, Chanwoo Choi