From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964800AbbBCJa3 (ORCPT ); Tue, 3 Feb 2015 04:30:29 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:34043 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932111AbbBCJaZ (ORCPT ); Tue, 3 Feb 2015 04:30:25 -0500 Message-ID: <54D09529.2000803@ti.com> Date: Tue, 3 Feb 2015 11:30:17 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Tony Lindgren , Semen Protsenko CC: , Subject: Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf References: <1422131320-1018-1-git-send-email-semen.protsenko@globallogic.com> <54C60A3A.1090008@ti.com> <20150202170827.GD9418@atomide.com> In-Reply-To: <20150202170827.GD9418@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/15 19:08, Tony Lindgren wrote: > * Roger Quadros [150126 01:38]: >> On 24/01/15 22:28, Semen Protsenko wrote: >>> Some GPMC_CONFIG7 register bits marked as "RESERVED", means they >>> shouldn't be overwritten. A typical approach to handle such bits called >>> "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf() >>> utilizes RMW technique, but implemented incorrectly. Due to obvious typo >>> in code read register value is being rewritten by another value, which >>> leads to loss of read RESERVED bits. This patch fixes this. >>> >>> While at it, replace magic numbers with named constants to improve code >>> readability. >>> >>> Signed-off-by: Semen Protsenko >> >> This is much nicer. >> >> Acked-by: Roger Quadros > > Roger will queue this so: > > Acked-by: Tony Lindgren > Thanks. Patches 1 and 2 queued for v3.21. https://github.com/rogerq/linux/tree/for-v3.21/gpmc-omap cheers, -roger