From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Gilad Avidov <gavidov@codeaurora.org>
Cc: sdharia@codeaurora.org, mlocke@codeaurora.org,
linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, iivanov@mm-sol.com,
galak@codeaurora.org, agross@codeaurora.org
Subject: Re: [PATCH V2 1/2] spmi: remove wakeup command before slave probe
Date: Tue, 03 Feb 2015 11:36:56 +0200 [thread overview]
Message-ID: <54D096B8.4060408@mm-sol.com> (raw)
In-Reply-To: <1422665201-25569-2-git-send-email-gavidov@codeaurora.org>
On 01/31/2015 02:46 AM, Gilad Avidov wrote:
> According to spmi spec a slave powers up into startup state and then
> transitions into active state. Thus, the wakeup command is not required
> before calling the slave's probe. The wakeup command is only needed for
> slaves that are in sleep state after receiving the sleep command.
>
> This is a bug since spmi master controllers, such as spmi-pmic-arb,
> which have no support for wakeup command return an error on that
> command and thus fail before reaching a slave driver probe.
>
> Cc: galak@codeaurora.org
> Acked-by: Sagar Dharia <sdharia@codeaurora.org>
> Signed-off-by: Gilad Avidov <gavidov@codeaurora.org>
> ---
> drivers/spmi/spmi.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
> index 1d92f51..9ff7454 100644
> --- a/drivers/spmi/spmi.c
> +++ b/drivers/spmi/spmi.c
> @@ -1,4 +1,4 @@
> -/* Copyright (c) 2012-2013, The Linux Foundation. All rights reserved.
> +/* Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.
run chackpatch please.
<snip>
--
regards,
Stan
next prev parent reply other threads:[~2015-02-03 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 0:46 [PATCH V2 0/2] add support for pmic_arb v2 and correct framework Gilad Avidov
2015-01-31 0:46 ` [PATCH V2 1/2] spmi: remove wakeup command before slave probe Gilad Avidov
2015-02-03 9:36 ` Stanimir Varbanov [this message]
2015-02-04 1:17 ` Gilad Avidov
2015-01-31 0:46 ` [PATCH V2 2/2] spmi: pmic_arb: add support for hw version 2 Gilad Avidov
2015-02-03 9:59 ` Stanimir Varbanov
2015-02-03 16:59 ` Gilad Avidov
2015-02-03 17:14 ` Stanimir Varbanov
2015-02-03 21:21 ` Lina Iyer
2015-02-04 14:36 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D096B8.4060408@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox