From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755078AbbBCJhI (ORCPT ); Tue, 3 Feb 2015 04:37:08 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:53041 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbbBCJhD (ORCPT ); Tue, 3 Feb 2015 04:37:03 -0500 Message-ID: <54D096B8.4060408@mm-sol.com> Date: Tue, 03 Feb 2015 11:36:56 +0200 From: Stanimir Varbanov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Gilad Avidov CC: sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, iivanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org Subject: Re: [PATCH V2 1/2] spmi: remove wakeup command before slave probe References: <1422665201-25569-1-git-send-email-gavidov@codeaurora.org> <1422665201-25569-2-git-send-email-gavidov@codeaurora.org> In-Reply-To: <1422665201-25569-2-git-send-email-gavidov@codeaurora.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2015 02:46 AM, Gilad Avidov wrote: > According to spmi spec a slave powers up into startup state and then > transitions into active state. Thus, the wakeup command is not required > before calling the slave's probe. The wakeup command is only needed for > slaves that are in sleep state after receiving the sleep command. > > This is a bug since spmi master controllers, such as spmi-pmic-arb, > which have no support for wakeup command return an error on that > command and thus fail before reaching a slave driver probe. > > Cc: galak@codeaurora.org > Acked-by: Sagar Dharia > Signed-off-by: Gilad Avidov > --- > drivers/spmi/spmi.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c > index 1d92f51..9ff7454 100644 > --- a/drivers/spmi/spmi.c > +++ b/drivers/spmi/spmi.c > @@ -1,4 +1,4 @@ > -/* Copyright (c) 2012-2013, The Linux Foundation. All rights reserved. > +/* Copyright (c) 2012-2015, The Linux Foundation. All rights reserved. run chackpatch please. -- regards, Stan