public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: mchehab@osg.samsung.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media:dvb-frontends: Change setting of variable interval to the correct values in the function, hd29l2_get_frontend for the switch statement checking the frame header
Date: Tue, 03 Feb 2015 12:20:18 +0200	[thread overview]
Message-ID: <54D0A0E2.3070808@iki.fi> (raw)
In-Reply-To: <1422935531-19353-1-git-send-email-xerofoify@gmail.com>

Yet another bad patch. Do not touch whole driver unless you understand 
and can test your patches!

Antti


On 02/03/2015 05:52 AM, Nicholas Krause wrote:
> This changes the switch statement checking the frame header of the pointer,
> c as a pointer to a structure of type,dtv_frontend_properties to set the
> variable,interval correctly in the switch statement for checking the frame
> header as part of this structure pointer,c for this function correctly as
> required by the cases in this switch statement.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>   drivers/media/dvb-frontends/hd29l2.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/hd29l2.c b/drivers/media/dvb-frontends/hd29l2.c
> index d7b9d54..3d1a013 100644
> --- a/drivers/media/dvb-frontends/hd29l2.c
> +++ b/drivers/media/dvb-frontends/hd29l2.c
> @@ -635,15 +635,15 @@ static int hd29l2_get_frontend(struct dvb_frontend *fe)
>   	switch ((buf[1] >> 0) & 0x03) {
>   	case 0: /* PN945 */
>   		str_guard_interval = "PN945";
> -		c->guard_interval = GUARD_INTERVAL_AUTO; /* FIXME */
> +		c->guard_interval = GUARD_INTERVAL_PN945;
>   		break;
>   	case 1: /* PN595 */
>   		str_guard_interval = "PN595";
> -		c->guard_interval = GUARD_INTERVAL_AUTO; /* FIXME */
> +		c->guard_interval = GUARD_INTERVAL_PN595;
>   		break;
>   	case 2: /* PN420 */
>   		str_guard_interval = "PN420";
> -		c->guard_interval = GUARD_INTERVAL_AUTO; /* FIXME */
> +		c->guard_interval = GUARD_INTERVAL_PN420;
>   		break;
>   	default:
>   		str_guard_interval = "?";
>

-- 
http://palosaari.fi/

           reply	other threads:[~2015-02-03 10:20 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1422935531-19353-1-git-send-email-xerofoify@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D0A0E2.3070808@iki.fi \
    --to=crope@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox