From: Lars-Peter Clausen <lars@metafoo.de>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI
Date: Tue, 03 Feb 2015 11:32:36 +0100 [thread overview]
Message-ID: <54D0A3C4.6010100@metafoo.de> (raw)
In-Reply-To: <1422958640-25723-2-git-send-email-Zubair.Kakakhel@imgtec.com>
On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote:
[...]
> V4 Changes
> Removed clock binding because of pending work in clock tree. Will add
> binding later. Rather than introduce a bad binding now and change later.
But this patch is introducing a bad binding. The part needs the clock to
work. The binding you are specifying right now says that it works fine
without any clocks.
> [...]
> +Example for jz4740:
> +
> +/ {
> + ohci: jz4780-ohci@0x134a0000 {
s/jz4780/jz4740
> + compatible = "ingenic,jz4740-ohci";
> + reg = <0x134a0000 0x10000>;
> +
> + interrupts = <5>;
> + };
> +};
> +
>
next prev parent reply other threads:[~2015-02-03 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 10:17 [PATCH_V4 0/3] usb: ohci: jz4740: Add DT support and a fix Zubair Lutfullah Kakakhel
2015-02-03 10:17 ` [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI Zubair Lutfullah Kakakhel
2015-02-03 10:32 ` Lars-Peter Clausen [this message]
2015-02-03 10:53 ` Zubair Lutfullah Kakakhel
2015-02-03 15:13 ` Lars-Peter Clausen
2015-02-03 11:54 ` Sergei Shtylyov
2015-02-03 10:17 ` [PATCH_V4 2/3] usb: ohci: jz4740: add DT support Zubair Lutfullah Kakakhel
2015-02-03 10:17 ` [PATCH_V4 3/3] usb: ohci: jz4740: prepare the clock before enabling it Zubair Lutfullah Kakakhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D0A3C4.6010100@metafoo.de \
--to=lars@metafoo.de \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox