From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755068AbbBCKcs (ORCPT ); Tue, 3 Feb 2015 05:32:48 -0500 Received: from smtp-out-017.synserver.de ([212.40.185.17]:1134 "EHLO smtp-out-017.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbbBCKcq (ORCPT ); Tue, 3 Feb 2015 05:32:46 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 5839 Message-ID: <54D0A3C4.6010100@metafoo.de> Date: Tue, 03 Feb 2015 11:32:36 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , stern@rowland.harvard.edu CC: gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI References: <1422958640-25723-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1422958640-25723-2-git-send-email-Zubair.Kakakhel@imgtec.com> In-Reply-To: <1422958640-25723-2-git-send-email-Zubair.Kakakhel@imgtec.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: [...] > V4 Changes > Removed clock binding because of pending work in clock tree. Will add > binding later. Rather than introduce a bad binding now and change later. But this patch is introducing a bad binding. The part needs the clock to work. The binding you are specifying right now says that it works fine without any clocks. > [...] > +Example for jz4740: > + > +/ { > + ohci: jz4780-ohci@0x134a0000 { s/jz4780/jz4740 > + compatible = "ingenic,jz4740-ohci"; > + reg = <0x134a0000 0x10000>; > + > + interrupts = <5>; > + }; > +}; > + >