From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965912AbbBCPNz (ORCPT ); Tue, 3 Feb 2015 10:13:55 -0500 Received: from smtp-out-020.synserver.de ([212.40.185.20]:1079 "EHLO smtp-out-017.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965669AbbBCPNL (ORCPT ); Tue, 3 Feb 2015 10:13:11 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 18751 Message-ID: <54D0E587.3060001@metafoo.de> Date: Tue, 03 Feb 2015 16:13:11 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , stern@rowland.harvard.edu CC: gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI References: <1422958640-25723-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1422958640-25723-2-git-send-email-Zubair.Kakakhel@imgtec.com> <54D0A3C4.6010100@metafoo.de> <54D0A8A6.5040805@imgtec.com> In-Reply-To: <54D0A8A6.5040805@imgtec.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2015 11:53 AM, Zubair Lutfullah Kakakhel wrote: > > On 03/02/15 10:32, Lars-Peter Clausen wrote: >> On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: >> [...] >>> V4 Changes >>> Removed clock binding because of pending work in clock tree. Will add >>> binding later. Rather than introduce a bad binding now and change later. >> >> But this patch is introducing a bad binding. The part needs the clock to work. The binding you are specifying right now says that it works fine without any clocks. > > Facing a chicken and egg problem with these patches here.. > > When the new clock driver gets in we can add the correct clock binding and replace > devm_clk_get(&pdev->dev, "uhc"); with devm_clk_get(&pdev->dev, NULL); > > Specifying the current binding got NAKed by Arnd who mentioned that clock names shouldn't be needed as required properties. > And even if needed, then it shouldn't be "uhc" and more close to what other ohci drivers have. It's not a chicken and egg problem. The order is very clear, first convert the clock driver to the CCF, then update the driver to pass NULL instead of "uhc", then add the devicetree bindings. - Lars