From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754220AbbBDBhh (ORCPT ); Tue, 3 Feb 2015 20:37:37 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:49051 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbbBDBhe (ORCPT ); Tue, 3 Feb 2015 20:37:34 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfee691-f79b86d000004a5a-b9-54d177db3409 Content-transfer-encoding: 8BIT Message-id: <54D177DB.3020705@samsung.com> Date: Wed, 04 Feb 2015 10:37:31 +0900 From: Jaewon Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 To: Mark Brown Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Chanwoo Choi , Sebastian Reichel , Beomho Seo Subject: Re: [PATCH v2 5/6] regulator: max77843: Add max77843 regulator driver References: <1422939846-29955-1-git-send-email-jaewon02.kim@samsung.com> <1422939846-29955-6-git-send-email-jaewon02.kim@samsung.com> <20150203162536.GQ21293@sirena.org.uk> In-reply-to: <20150203162536.GQ21293@sirena.org.uk> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsWyRsSkSPd2+cUQg+utphanP21jt5j68Amb xfUvz1kt5h85x2rR/2Yhq8W5VysZLSbdn8Bicf/rUUaLy7vmsFl87j3CaLH0+kUmiwnT17JY tO49wm5x/NNBFovTu0sc+D3WzFvD6HG5r5fJY+XyL2wem1Z1snncubaHzaNvyypGj8+b5ALY o7hsUlJzMstSi/TtErgyemZcZinYzVkx60UrawPjdfYuRk4OCQETiW3Xv0DZYhIX7q1n62Lk 4hASWMooseloBxNM0eKT/xlBbCGB6YwSZ1p5QGxeAUGJH5PvsXQxcnAwC8hLHLmUDRJmFjCT eNSyjhlizmtGicY/J1lBangFtCRefBYFqWERUJWY/7qZDcRmE9CW+L5+MSuILSoQITH/2Gtm EFtEQFni6ve9LBAzfzBL/H0OdoKwgJ9E/9MDTBDzNzBKbLzRCpbgFDCWaFnxFCwhITCTQ+Lb o1dsENsEJL5NPgR2qISArMSmA8wQf0lKHFxxg2UCo9gsJO/MQnhnFpJ3FjAyr2IUTS1ILihO Si8y1StOzC0uzUvXS87P3cQIjOrT/55N3MF4/4D1IUYBDkYlHl6B/IshQqyJZcWVuYcYTYGO mMgsJZqcD0wdeSXxhsZmRhamJqbGRuaWZkrivDrSP4OFBNITS1KzU1MLUovii0pzUosPMTJx cEo1MO5Iu5h3WnG17UyvUh7GRv+PC613nFGKn2iZ0Rz0Y07H3hb3u+d2+Ot7T3djO7jBcu38 Na28z9UPXzrYK2u6pdl77dqZKgZrP69a0rR+0bqny6WYTTpz9wg7Vh4LOKm1JMh4/s9rb9++ lGvY+n1ea/Bd0UW7HBZdTChtNHlZ++Hto02Vi7yNFxUrsRRnJBpqMRcVJwIA1qZHV+UCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jQd3b5RdDDDb061ic/rSN3WLqwyds Fte/PGe1mH/kHKtF/5uFrBbnXq1ktJh0fwKLxf2vRxktLu+aw2bxufcIo8XS6xeZLCZMX8ti 0br3CLvF8U8HWSxO7y5x4PdYM28No8flvl4mj5XLv7B5bFrVyeZx59oeNo++LasYPT5vkgtg j2pgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBOlxJ oSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmNEz4zJLwW7OilkvWlkbGK+z dzFyckgImEgsPvmfEcIWk7hwbz0biC0kMJ1R4kwrD4jNKyAo8WPyPZYuRg4OZgF5iSOXskHC zAJmEo9a1jF3MXIBlb9mlGj8c5IVpIZXQEvixWdRkBoWAVWJ+a+bwUayCWhLfF+/mBXEFhWI kJh/7DUziC0ioCxx9fteFoiZP5gl/j4HO0dYwE+i/+kBJoj5GxglNt5oBUtwChhLtKx4yjSB UWAWkvNmIZw3C8l5CxiZVzGKphYkFxQnpeca6RUn5haX5qXrJefnbmIEp4xn0jsYVzVYHGIU 4GBU4uEVyL8YIsSaWFZcmXuIUYKDWUmEty8GKMSbklhZlVqUH19UmpNafIjRFOi7icxSosn5 wHSWVxJvaGxiZmRpZG5oYWRsriTOq2TfFiIkkJ5YkpqdmlqQWgTTx8TBKdXAuHVhgNL3ezdq t6XKnmyLml+SZfl4a//hY5zKS6ZL/JMq9wxSeL8odu8fM846iSqmLClTltB+ncy36lHVmb7X t9mz/v1a/JLLS3TKu6evE2eemiu7yXNh4GPu94xeG5Y+Z2b81XH/Se2k/0y1fr4GB7xz8qIc 3RtcVdx2t3sJb1bn+fBsgY64EktxRqKhFnNRcSIAgsAHLy8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, 2015년 02월 04일 01:25에 Mark Brown 이(가) 쓴 글: > On Tue, Feb 03, 2015 at 02:04:05PM +0900, Jaewon Kim wrote: >> This patch adds new regulator driver to support max77843 >> MFD(Multi Function Device) chip`s regulators. >> The Max77843 has two voltage regulators for USB safeout. > This looks mostly good, a couple of very small things: > >> +static const struct regulator_desc max77843_supported_regulators[] = { >> + [MAX77843_SAFEOUT1] = { >> + .name = "SAFEOUT1", >> + .id = MAX77843_SAFEOUT1, >> + .ops = &max77843_regulator_ops, >> + .of_match = of_match_ptr("SAFEOUT1"), >> + .regulators_node = of_match_ptr("regulators"), >> + .type = REGULATOR_VOLTAGE, >> + .owner = THIS_MODULE, >> + .n_voltages = MAX77843_SUPPORTED_VOLTAGE_NUM, >> + .volt_table = max77843_regulator_table, > It's better to make n_voltages be ARRAY_SIZE() for the table, that way > there's no need to keep the define and array lined up if someone extends > the driver. A name like _safeout_voltage_table might be clearer too. I will change n_voltages value to ARRAY_SIZE() instead of define. And fix volt_table enum variable name. Thanks to advise. Thanks Jaewon Kim