From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161575AbbBDURV (ORCPT ); Wed, 4 Feb 2015 15:17:21 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:43825 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161055AbbBDURS (ORCPT ); Wed, 4 Feb 2015 15:17:18 -0500 Message-ID: <54D27E4B.1090807@acm.org> Date: Wed, 04 Feb 2015 14:17:15 -0600 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Nicholas Krause CC: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] char:ipmi: Free ipmi_recv_msg messages from the linked list,recv_msgs for the function,ipmi_release in the file,ipmi_devintf.c References: <1422681474-18915-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1422681474-18915-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've been debating what to do with this, but the patch makes a good change, so I'll go ahead with it. I am going to remove the unnecessary braces. In the future, you really need to be able to test the changes you make. So you really need to work in an area that you can test in. If you are really interested in learning, you have a ways to go, I think, and the kernel may not be the best place to do that learning. -corey On 01/30/2015 11:17 PM, Nicholas Krause wrote: > This adds a loop through the elements in the linked list, recv_msgs using > list_for_entry_safe in order to free messages in this list. In addition > we are using the safe version of this marco in order to prevent use after > bugs related to deleting the element we are on currently by holding a > pointer to the next element after the current one we are on and freeing > with the function, ipmi_free_recv_msg internally in this loop. > > Signed-off-by: Nicholas Krause > --- > drivers/char/ipmi/ipmi_devintf.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c > index ec318bf..235a1fa 100644 > --- a/drivers/char/ipmi/ipmi_devintf.c > +++ b/drivers/char/ipmi/ipmi_devintf.c > @@ -157,12 +157,17 @@ static int ipmi_release(struct inode *inode, struct file *file) > { > struct ipmi_file_private *priv = file->private_data; > int rv; > + struct ipmi_recv_msg *msg, *next; > > rv = ipmi_destroy_user(priv->user); > if (rv) > return rv; > > - /* FIXME - free the messages in the list. */ > + list_for_each_entry_safe(msg, next, &priv->recv_msgs, link) { > + ipmi_free_recv_msg(msg); > + } > + > + > kfree(priv); > > return 0;