From: Stephen Boyd <sboyd@codeaurora.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Lee Jones <lee@kernel.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v1] clkdev: change prototype of clk_register_clkdev()
Date: Wed, 04 Feb 2015 15:18:47 -0800 [thread overview]
Message-ID: <54D2A8D7.6030806@codeaurora.org> (raw)
In-Reply-To: <1422987534-21832-2-git-send-email-andriy.shevchenko@linux.intel.com>
On 02/03/15 10:18, Andy Shevchenko wrote:
> Since clk_register_clkdev() is exported for modules the caller should get a
> pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> the ->remove() stage.
>
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
The idea seems ok to me. Please Cc Russell on the next version. It would
also be good to make a note that this patch doesn't attempt to fix any
memory leaks that may exist by adding calls to clkdev_drop().
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-02-04 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 18:18 [PATCH v1] clkdev: prevent potential memory leak when used in modules Andy Shevchenko
2015-02-03 18:18 ` [PATCH v1] clkdev: change prototype of clk_register_clkdev() Andy Shevchenko
2015-02-04 15:50 ` Mika Westerberg
2015-02-04 16:03 ` Andy Shevchenko
2015-02-04 23:18 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D2A8D7.6030806@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bryanh@codeaurora.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@linaro.org \
--cc=ralf@linux-mips.org \
--cc=s.nawrocki@samsung.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox