From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751513AbbBEGWy (ORCPT ); Thu, 5 Feb 2015 01:22:54 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:45788 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbbBEGWw (ORCPT ); Thu, 5 Feb 2015 01:22:52 -0500 Message-ID: <54D30BE5.4070906@ti.com> Date: Thu, 5 Feb 2015 11:51:25 +0530 From: Vignesh R User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Lee Jones CC: Jonathan Cameron , Hartmut Knaack , Dmitry Torokhov , Sebastian Andrzej Siewior , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King , Lars-Peter Clausen , Peter Meerwald , Samuel Ortiz , Brad Griffis , Paul Gortmaker , Sanjeev Sharma , Jan Kardell , Felipe Balbi , Wolfram Sang , , , , , , Subject: Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save References: <1420609779-11156-1-git-send-email-vigneshr@ti.com> <1420609779-11156-4-git-send-email-vigneshr@ti.com> <20150120115325.GK13701@x1> <54BE4CD1.1020709@ti.com> <20150120160410.GL13701@x1> <54BF7C14.1080907@ti.com> In-Reply-To: <54BF7C14.1080907@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 21 January 2015 03:44 PM, Vignesh R wrote: > On Tuesday 20 January 2015 09:34 PM, Lee Jones wrote: >> On Tue, 20 Jan 2015, R, Vignesh wrote: >>> On 1/20/2015 5:23 PM, Lee Jones wrote: >>>> On Wed, 07 Jan 2015, Vignesh R wrote: >>>> >>>>> In one shot mode, sequencer automatically disables all enabled steps at >>>>> the end of each cycle. (both ADC steps and TSC steps) Hence these steps >>>>> need not be saved in reg_se_cache for clearing these steps at a later >>>>> stage. >>>>> Also, when ADC wakes up Sequencer should not be busy executing any of the >>>>> config steps except for the charge step. Previously charge step was 1 ADC >>>>> clock cycle and hence it was ignored. >>>>> TSC steps are always disabled at the end of each conversion cycle, hence >>>>> there is no need to explicitly disable TSC steps by writing 0 to REG_SE. >>>>> >>>>> Signed-off-by: Vignesh R >>>>> --- >>>>> >>>>> v5: >>>>> - Remove unnecessary clearing of REG_SE >>>>> >>>>> drivers/mfd/ti_am335x_tscadc.c | 13 +++++-------- >>>>> include/linux/mfd/ti_am335x_tscadc.h | 1 + >>>>> 2 files changed, 6 insertions(+), 8 deletions(-) >>>> >>>> Looks fine. >>>> >>>> For my own reference: >>>> Acked-by: Lee Jones >>>> >>>> Can this patch be applied on its own? >>>> >>> >>> I prefer to wait until input patches are picked up. >> >> I have no problem with that, but is there a technical reason why? >> > > Nothing, in particular. This patch alone has no impact on the > performance of TSC/ADC unit. Patch 2/6 is necessary to observe the > changes caused by this series. Hence, please wait until those patches > are picked up. Input maintainer has applied other patches. You can pick this one. Regards Vignesh R