public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	mturquette@linaro.org
Cc: tomasz.figa@gmail.com, kgene@kernel.org, inki.dae@samsung.com,
	chanho61.park@samsung.com, sw0312.kim@samsung.com,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [v3,1/9] clk: samsung: exynos5433: Add clocks for CMU_APOLLO domain
Date: Thu, 05 Feb 2015 10:56:54 +0100	[thread overview]
Message-ID: <54D33E66.30909@samsung.com> (raw)
In-Reply-To: <54D31F67.1050701@samsung.com>

On 05/02/15 08:44, Pankaj Dubey wrote:
>> +static struct samsung_gate_clock apollo_gate_clks[] __initdata = {

>> > +
>> > +	/* ENABLE_PCLK_APOLLO */
>> > +	GATE(CLK_PCLK_ASAPBMST_CSSYS_APOLLO, "pclk_asapbmst_cssys_apollo",
>> > +			"div_pclk_dbg_apollo", ENABLE_PCLK_APOLLO,
>> > +			2, CLK_IGNORE_UNUSED, 0),
>> > +	GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo",
>> > +			ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0),
>> > +	GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo",
>
> Isn't "pclk_pmu_sysreg_apollo" be named as "pclk_sysreg_apollo" to match 
> with UM?

Sounds reasonable, Chanwoo, if you agree I'll squash following change
to this patch before sending upstream:

diff --git a/drivers/clk/samsung/clk-exynos5433.c
b/drivers/clk/samsung/clk-exynos5433.c
index 7a024cd..387e3e3 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -3656,7 +3656,7 @@ static struct samsung_gate_clock apollo_gate_clks[]
__initdata = {
                        2, CLK_IGNORE_UNUSED, 0),
        GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo",
                        ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0),
-       GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo",
+       GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_sysreg_apollo",
                        "div_pclk_apollo", ENABLE_PCLK_APOLLO,
                        0, CLK_IGNORE_UNUSED, 0),
--
Thanks,
Sylwester

  reply	other threads:[~2015-02-05  9:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03  0:13 [PATCH v3 0/9] clk: samsung: Add clocks for remaining domains of Exynos5433 Chanwoo Choi
2015-02-03  0:13 ` [PATCH v3 1/9] clk: samsung: exynos5433: Add clocks for CMU_APOLLO domain Chanwoo Choi
2015-02-05  7:44   ` [v3,1/9] " Pankaj Dubey
2015-02-05  9:56     ` Sylwester Nawrocki [this message]
2015-02-05 13:42       ` Chanwoo Choi
2015-02-03  0:13 ` [PATCH v3 2/9] clk: samsung: exynos5433: Add clocks for CMU_ATLAS domain Chanwoo Choi
2015-02-05  8:13   ` [v3,2/9] " Pankaj Dubey
2015-02-03  0:13 ` [PATCH v3 3/9] clk: samsung: exynos5433: Add clocks for CMU_MSCL domain Chanwoo Choi
2015-02-05  8:30   ` [v3,3/9] " Pankaj Dubey
2015-02-03  0:13 ` [PATCH v3 4/9] clk: samsung: exynos5433: Add clocks for CMU_MFC domain Chanwoo Choi
2015-02-03  0:13 ` [PATCH v3 5/9] clk: samsung: exynos5433: Add clocks for CMU_HEVC domain Chanwoo Choi
2015-02-03  0:13 ` [PATCH v3 6/9] clk: samsung: exynos5433: Add clocks for CMU_ISP domain Chanwoo Choi
2015-02-03  0:13 ` [PATCH v3 7/9] clk: samsung: exynos5433: Add clocks for CMU_CAM0 domain Chanwoo Choi
2015-02-03  0:13 ` [PATCH v3 8/9] clk: samsung: exynos5433: Add clocks for CMU_CAM1 domain Chanwoo Choi
2015-02-03  0:13 ` [PATCH v3 9/9] clk: samsung: Add CLKOUT driver support for Exynos5433 SoC Chanwoo Choi
2015-02-04  1:12 ` [PATCH] clk: samsung: exynos5433: Move CLK_SCLK_HDMI_SPDIF_DISP clock to CMU_TOP domain Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D33E66.30909@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=inki.dae@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=pankaj.dubey@samsung.com \
    --cc=sw0312.kim@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox