From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Andrzej Hajda <a.hajda@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Liquid.Acid@gmx.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x
Date: Thu, 05 Feb 2015 15:45:08 +0100 [thread overview]
Message-ID: <54D381F4.2080701@collabora.co.uk> (raw)
In-Reply-To: <1423139739-19881-1-git-send-email-a.hajda@samsung.com>
Hello Andrzej,
Thanks a lot for finally finding what was causing the HDMI issue.
On 02/05/2015 01:35 PM, Andrzej Hajda wrote:
> Hi,
>
> Exynos chipsets since 542x have asynchronous bridges connecting different IPs.
> These bridges should be operational during power domain switching, ie associated
> clocks cannot be gated.
> This patchset adds binding to provide such clocks per power domain and adds code
> which enables them during domain on/off operation.
>
> This patchset fixes power domain issues with disp1 domain and HDMI (some of them)
> on Odroid XU3:
> - disp1 power domain can be turned off,
> - no more "imprecise external abort" faults.
>
> The patchset is based on '[PATCH v5 0/9] Enable HDMI support on Exynos platforms' [1].
>
It also depends on '[PATCH 0/2] Add HDMI support for Exynos5420 platform' [2].
> It was successfully tested on OdroidXU3.
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743
Your patches looks good to me so please feel free to add:
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
I also tested on an Exynos5420 Peach Pit Chromebook and both the "Power
domain power-domain disable failed" message and the system crash are gone.
Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
[2]: https://lkml.org/lkml/2015/1/20/235
next prev parent reply other threads:[~2015-02-05 14:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 12:35 [RFC PATCH 0/3] Fix power domains handling on exynos542x Andrzej Hajda
2015-02-05 12:35 ` [RFC PATCH 1/3] arm/exynos: add asynchronous bridge clock bindings Andrzej Hajda
2015-02-05 12:35 ` [RFC PATCH 2/3] arm/exynos/pm_domains: add support for async-bridge clocks Andrzej Hajda
2015-03-12 13:05 ` Sylwester Nawrocki
2015-02-05 12:35 ` [RFC PATCH 3/3] ARM: dts: exynos5420: add async-bridge clock to disp1 power domain Andrzej Hajda
2015-02-05 14:45 ` Javier Martinez Canillas [this message]
2015-02-06 5:27 ` [RFC PATCH 0/3] Fix power domains handling on exynos542x Joonyoung Shim
2015-02-06 9:18 ` Javier Martinez Canillas
2015-02-06 10:55 ` [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain Andrzej Hajda
2015-02-06 11:27 ` Javier Martinez Canillas
2015-03-03 8:12 ` Javier Martinez Canillas
2015-03-12 13:00 ` Sylwester Nawrocki
2015-03-10 9:48 ` [RFC PATCH 0/3] Fix power domains handling on exynos542x Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D381F4.2080701@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=Liquid.Acid@gmx.net \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox