From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754823AbbBFKra (ORCPT ); Fri, 6 Feb 2015 05:47:30 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29742 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbbBFKr2 (ORCPT ); Fri, 6 Feb 2015 05:47:28 -0500 Message-ID: <54D49BB5.5000708@oracle.com> Date: Fri, 06 Feb 2015 18:47:17 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: =?windows-1252?Q?Roger_Pau_Monn=E9?= CC: xen-devel@lists.xen.org, david.vrabel@citrix.com, linux-kernel@vger.kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, wei.liu2@citrix.com Subject: Re: [PATCH 2/2] drivers: xen/block: add multi-page ring support References: <1422008071-27643-1-git-send-email-bob.liu@oracle.com> <1422008071-27643-2-git-send-email-bob.liu@oracle.com> <54CF54CB.70008@citrix.com> In-Reply-To: <54CF54CB.70008@citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2015 06:43 PM, Roger Pau Monné wrote: > El 23/01/15 a les 10.14, Bob Liu ha escrit: >> Extend xen/block to support multi-page ring. >> * xen-blkback notify blkfront with feature-multi-ring-pages >> * xen-blkfront write to xenstore about how many pages are used as the ring >> >> If using 4 pages as the ring, inflight requests inscreased from 32 to 128 and >> IOPS improved nearly 400% on our system. >> >> Signed-off-by: Bob Liu >> --- >> drivers/block/xen-blkback/xenbus.c | 86 +++++++++++++++++++++++++-------- >> drivers/block/xen-blkfront.c | 94 ++++++++++++++++++++++++++---------- > > This requires a patch to xen/include/public/io/blkif.h in the Xen > repository describing how this protocol extension is going to work > before reviewing the Linux implementation. > But there is no protocol change, just add an parameter "max_ring_pages" to control how many pages can be used as the ring. Now with one page we can only have 32 requests. -- Regards, -Bob