From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbbBFNnv (ORCPT ); Fri, 6 Feb 2015 08:43:51 -0500 Received: from mail-la0-f49.google.com ([209.85.215.49]:40426 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbbBFNnt (ORCPT ); Fri, 6 Feb 2015 08:43:49 -0500 Message-ID: <54D4C512.1010107@cogentembedded.com> Date: Fri, 06 Feb 2015 16:43:46 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Nicholas Mc Guire CC: Nicholas Mc Guire , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: image: use msecs_to_jiffies for time conversion References: <1423216221-29094-1-git-send-email-hofrat@osadl.org> <54D4B34B.7030408@cogentembedded.com> <20150206133656.GA29868@opentech.at> In-Reply-To: <20150206133656.GA29868@opentech.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/6/2015 4:36 PM, Nicholas Mc Guire wrote: >>> This is only an API consolidation and should make things more readable >>> it replaces var * HZ / 1000 by msecs_to_jiffies(var). >>> Signed-off-by: Nicholas Mc Guire >>> --- >>> Note that the indentation is not aligned with the correct ( here due to >>> lines going over 80 char - not sure if this is the right way to resolve >>> this (this file has quite a few coding style issues). >>> Patch was only compile tested with x86_64_defconfig + CONFIG_USB_MDC800=m >>> Patch is against 3.19.0-rc7 (localversion-next is -next-20150204) >>> drivers/usb/image/mdc800.c | 11 +++++++---- >>> 1 file changed, 7 insertions(+), 4 deletions(-) >>> diff --git a/drivers/usb/image/mdc800.c b/drivers/usb/image/mdc800.c >>> index a62865a..3a72e8f 100644 >>> --- a/drivers/usb/image/mdc800.c >>> +++ b/drivers/usb/image/mdc800.c >> [...] >>> @@ -743,8 +744,9 @@ static ssize_t mdc800_device_read (struct file *file, char __user *buf, size_t l >>> mutex_unlock(&mdc800->io_lock); >>> return len-left; >>> } >>> - wait_event_timeout(mdc800->download_wait, mdc800->downloaded, >>> - TO_DOWNLOAD_GET_READY*HZ/1000); >>> + wait_event_timeout(mdc800->download_wait, >>> + mdc800->downloaded, >>> + msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); >> Don't indent with spaces (you're not aligning to open paren anyway), >> use the final tab instead, please. > thanks ! In the diff output that problem is actually not well visible. > was not really clear on how to do this properly - the problem with > using the last tab stop is that you then get the following code > wait_event_timeout(mdc800->download_wait, > mdc800->downloaded, > msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); > mdc800->downloaded = 0; > which semed really bad and Yes, it's horrible. > wait_event_timeout(mdc800->download_wait, > mdc800->downloaded, > msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); > mdc800->downloaded = 0; > makes it atleast somewhat readable. If I indent a full tab ghen it goes over > 80 char. Ah, I didn't realize that, sorry. > So in this case - should one use the last tab-stop anyway ? Probably not. > thx! > hofrat WBR, Sergei