From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbbBFOCO (ORCPT ); Fri, 6 Feb 2015 09:02:14 -0500 Received: from bhuna.collabora.co.uk ([93.93.135.160]:59420 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbbBFOCM (ORCPT ); Fri, 6 Feb 2015 09:02:12 -0500 Message-ID: <54D4C95D.30909@collabora.com> Date: Fri, 06 Feb 2015 15:02:05 +0100 From: Tomeu Vizoso User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stephen Boyd , Mike Turquette CC: linux-kernel@vger.kernel.org, Alban Browaeys Subject: Re: [PATCH 2/3] clk: Rename child_node to clks_node to avoid confusion References: <1423181968-32149-1-git-send-email-sboyd@codeaurora.org> <1423181968-32149-3-git-send-email-sboyd@codeaurora.org> In-Reply-To: <1423181968-32149-3-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2015 01:19 AM, Stephen Boyd wrote: > The child_node member of struct clk is named the same as the > child_node member of struct clk_core. Let's rename the struct > clk's member to clks_node to avoid getting confused with the > child_node member of struct clk_core and to match the name of the > list head, clks. > > Cc: Tomeu Vizoso > Cc: Alban Browaeys > Signed-off-by: Stephen Boyd > --- > drivers/clk/clk.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Yeah, I like this better. Reviewed-by: Tomeu Vizoso Thanks, Tomeu > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 5469d7714f5d..315dc22b7356 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -83,7 +83,7 @@ struct clk { > const char *con_id; > unsigned long min_rate; > unsigned long max_rate; > - struct hlist_node child_node; > + struct hlist_node clks_node; > }; > > /*** locking ***/ > @@ -851,10 +851,10 @@ static void clk_core_get_boundaries(struct clk_core *clk, > *min_rate = 0; > *max_rate = ULONG_MAX; > > - hlist_for_each_entry(clk_user, &clk->clks, child_node) > + hlist_for_each_entry(clk_user, &clk->clks, clks_node) > *min_rate = max(*min_rate, clk_user->min_rate); > > - hlist_for_each_entry(clk_user, &clk->clks, child_node) > + hlist_for_each_entry(clk_user, &clk->clks, clks_node) > *max_rate = min(*max_rate, clk_user->max_rate); > } > > @@ -2376,7 +2376,7 @@ struct clk *__clk_create_clk(struct clk_hw *hw, const char *dev_id, > clk->max_rate = ULONG_MAX; > > clk_prepare_lock(); > - hlist_add_head(&clk->child_node, &hw->core->clks); > + hlist_add_head(&clk->clks_node, &hw->core->clks); > clk_prepare_unlock(); > > return clk; > @@ -2385,7 +2385,7 @@ struct clk *__clk_create_clk(struct clk_hw *hw, const char *dev_id, > void __clk_free_clk(struct clk *clk) > { > clk_prepare_lock(); > - hlist_del(&clk->child_node); > + hlist_del(&clk->clks_node); > clk_prepare_unlock(); > > kfree(clk); > @@ -2663,7 +2663,7 @@ void __clk_put(struct clk *clk) > > clk_prepare_lock(); > > - hlist_del(&clk->child_node); > + hlist_del(&clk->clks_node); > clk_core_set_rate_nolock(clk->core, clk->core->req_rate); > owner = clk->core->owner; > kref_put(&clk->core->ref, __clk_release); >