From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbbBFRL7 (ORCPT ); Fri, 6 Feb 2015 12:11:59 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:43038 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbbBFRL5 (ORCPT ); Fri, 6 Feb 2015 12:11:57 -0500 Message-ID: <54D4F5DC.5060205@codeaurora.org> Date: Fri, 06 Feb 2015 09:11:56 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Tomeu Vizoso , Mike Turquette CC: linux-kernel@vger.kernel.org, Sylwester Nawrocki , Alban Browaeys Subject: Re: [PATCH v2] clkdev: Always allocate a struct clk and call __clk_get() w/ CCF References: <1423186850-32547-1-git-send-email-sboyd@codeaurora.org> <54D4B4E5.6020003@collabora.com> In-Reply-To: <54D4B4E5.6020003@collabora.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/15 04:34, Tomeu Vizoso wrote: > On 02/06/2015 02:40 AM, Stephen Boyd wrote: > >> @@ -209,17 +205,13 @@ struct clk *clk_get_sys(const char *dev_id, const char *con_id) >> if (!cl) >> goto out; >> >> - if (!__clk_get(cl->clk)) { >> + clk = __clk_create_clk(__clk_get_hw(cl->clk), dev_id, con_id); > We need to check for clk being an error either here or in __clk_get > because __clk_create_clk can return -ENOMEM. Good catch. Thanks. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project