From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758561AbbBFS3S (ORCPT ); Fri, 6 Feb 2015 13:29:18 -0500 Received: from mout.web.de ([212.227.15.4]:52413 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754732AbbBFS3P (ORCPT ); Fri, 6 Feb 2015 13:29:15 -0500 Message-ID: <54D507F4.5010704@users.sourceforge.net> Date: Fri, 06 Feb 2015 19:29:08 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] SCSI-csiostor: Delete an unnecessary check before the function call "release_firmware" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:H5mjqEOpizwVPYDsUIGHbuFW6qkUG1u8KtfnyreiUJCoeTJxTWK mvSsDsFbD83VfLgGzPx0vilvYIUQcRbEyMxIKXyyPIzqaQao8frx3IiS7QI8h816hwUsQ8N qaquJLnYVkxe5MUstMT6aafI9vNOVsrr764vGomacVYTpYvnpfybXffO8M7cfUosDSV4zrS y+NXZHAM41u5qcDPG9law== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Feb 2015 19:10:25 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/scsi/csiostor/csio_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c index 35c5f83..37fa8bf 100644 --- a/drivers/scsi/csiostor/csio_hw.c +++ b/drivers/scsi/csiostor/csio_hw.c @@ -2117,8 +2117,7 @@ csio_hw_flash_fw(struct csio_hw *hw, int *reset) hw->fw_state, reset); /* Cleaning up */ - if (fw != NULL) - release_firmware(fw); + release_firmware(fw); kfree(card_fw); return ret; } -- 2.2.2