public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Tolga Ceylan <tolga.ceylan@gmail.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Josef Gajdusek <atx@atalax.net>,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: iio: Coding Style Correction
Date: Sun, 08 Feb 2015 11:52:38 +0000	[thread overview]
Message-ID: <54D74E06.2030302@kernel.org> (raw)
In-Reply-To: <1423382693-4189-1-git-send-email-tolga.ceylan@gmail.com>

On 08/02/15 08:04, Tolga Ceylan wrote:
> Indentation corrections in struct initializations and
> one line over 80 characters split into two lines
> 
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
Whilst I find it hard to be inspired by these sort of patches,
you have presented the patch well and it's entirely sensible.
Only slight niggle that I've fixed is your patch title doesn't mention
the driver in question (and hence is identical to the other patch you
submitted at a quick glance).

Anyhow, applied to the togreg branch of iio.git which will get
pushed out as testing sometime soonish - perhaps controlled by when
my plane actually shows up today....
> ---
>  drivers/staging/iio/magnetometer/hmc5843_i2c.c | 34 +++++++++++++-------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_i2c.c b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> index 6acd614..e221a58 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> @@ -19,49 +19,49 @@
>  #include "hmc5843.h"
>  
>  static const struct regmap_range hmc5843_readable_ranges[] = {
> -		regmap_reg_range(0, HMC5843_ID_END),
> +	regmap_reg_range(0, HMC5843_ID_END),
>  };
>  
>  static struct regmap_access_table hmc5843_readable_table = {
> -		.yes_ranges = hmc5843_readable_ranges,
> -		.n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges),
> +	.yes_ranges = hmc5843_readable_ranges,
> +	.n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges),
>  };
>  
>  static const struct regmap_range hmc5843_writable_ranges[] = {
> -		regmap_reg_range(0, HMC5843_MODE_REG),
> +	regmap_reg_range(0, HMC5843_MODE_REG),
>  };
>  
>  static struct regmap_access_table hmc5843_writable_table = {
> -		.yes_ranges = hmc5843_writable_ranges,
> -		.n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges),
> +	.yes_ranges = hmc5843_writable_ranges,
> +	.n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges),
>  };
>  
>  static const struct regmap_range hmc5843_volatile_ranges[] = {
> -		regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG),
> +	regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG),
>  };
>  
>  static struct regmap_access_table hmc5843_volatile_table = {
> -		.yes_ranges = hmc5843_volatile_ranges,
> -		.n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges),
> +	.yes_ranges = hmc5843_volatile_ranges,
> +	.n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges),
>  };
>  
>  static struct regmap_config hmc5843_i2c_regmap_config = {
> -		.reg_bits = 8,
> -		.val_bits = 8,
> +	.reg_bits = 8,
> +	.val_bits = 8,
>  
> -		.rd_table = &hmc5843_readable_table,
> -		.wr_table = &hmc5843_writable_table,
> -		.volatile_table = &hmc5843_volatile_table,
> +	.rd_table = &hmc5843_readable_table,
> +	.wr_table = &hmc5843_writable_table,
> +	.volatile_table = &hmc5843_volatile_table,
>  
> -		.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_RBTREE,
>  };
>  
>  static int hmc5843_i2c_probe(struct i2c_client *client,
>  			 const struct i2c_device_id *id)
>  {
>  	return hmc5843_common_probe(&client->dev,
> -			devm_regmap_init_i2c(client, &hmc5843_i2c_regmap_config),
> -			id->driver_data);
> +		devm_regmap_init_i2c(client, &hmc5843_i2c_regmap_config),
> +		id->driver_data);
>  }
>  
>  static int hmc5843_i2c_remove(struct i2c_client *client)
> 


  reply	other threads:[~2015-02-08 11:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08  8:04 [PATCH 1/1] Staging: iio: Coding Style Correction Tolga Ceylan
2015-02-08 11:52 ` Jonathan Cameron [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-08  7:40 [PATCH 1/1] Staging: iio: Coding style correction Tolga Ceylan
2015-02-08 11:55 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D74E06.2030302@kernel.org \
    --to=jic23@kernel.org \
    --cc=atx@atalax.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=tolga.ceylan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox