* [PATCH 1/1] Staging: iio: Coding style correction
@ 2015-02-08 7:40 Tolga Ceylan
2015-02-08 11:55 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Tolga Ceylan @ 2015-02-08 7:40 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
Cc: tolga.ceylan
Line over 80 characters corrected
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/iio/meter/ade7854-i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
index 5b33c7f..5d0671a 100644
--- a/drivers/staging/iio/meter/ade7854-i2c.c
+++ b/drivers/staging/iio/meter/ade7854-i2c.c
@@ -195,7 +195,8 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
if (ret)
goto out;
- *val = (st->rx[0] << 24) | (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3];
+ *val = (st->rx[0] << 24) | (st->rx[1] << 16) |
+ (st->rx[2] << 8) | st->rx[3];
out:
mutex_unlock(&st->buf_lock);
return ret;
--
2.3.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Staging: iio: Coding style correction
2015-02-08 7:40 [PATCH 1/1] Staging: iio: Coding style correction Tolga Ceylan
@ 2015-02-08 11:55 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2015-02-08 11:55 UTC (permalink / raw)
To: Tolga Ceylan, Lars-Peter Clausen, Michael Hennerich,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On 08/02/15 07:40, Tolga Ceylan wrote:
> Line over 80 characters corrected
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
Applied, again with an amended patch title to reflect the driver
it is changing rather that simply the subsystem.
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 5b33c7f..5d0671a 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -195,7 +195,8 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
> if (ret)
> goto out;
>
> - *val = (st->rx[0] << 24) | (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3];
> + *val = (st->rx[0] << 24) | (st->rx[1] << 16) |
> + (st->rx[2] << 8) | st->rx[3];
> out:
> mutex_unlock(&st->buf_lock);
> return ret;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] Staging: iio: Coding Style Correction
@ 2015-02-08 8:04 Tolga Ceylan
2015-02-08 11:52 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Tolga Ceylan @ 2015-02-08 8:04 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Greg Kroah-Hartman, Josef Gajdusek, Tolga Ceylan,
linux-iio, devel, linux-kernel
Indentation corrections in struct initializations and
one line over 80 characters split into two lines
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/iio/magnetometer/hmc5843_i2c.c | 34 +++++++++++++-------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/iio/magnetometer/hmc5843_i2c.c b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
index 6acd614..e221a58 100644
--- a/drivers/staging/iio/magnetometer/hmc5843_i2c.c
+++ b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
@@ -19,49 +19,49 @@
#include "hmc5843.h"
static const struct regmap_range hmc5843_readable_ranges[] = {
- regmap_reg_range(0, HMC5843_ID_END),
+ regmap_reg_range(0, HMC5843_ID_END),
};
static struct regmap_access_table hmc5843_readable_table = {
- .yes_ranges = hmc5843_readable_ranges,
- .n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges),
+ .yes_ranges = hmc5843_readable_ranges,
+ .n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges),
};
static const struct regmap_range hmc5843_writable_ranges[] = {
- regmap_reg_range(0, HMC5843_MODE_REG),
+ regmap_reg_range(0, HMC5843_MODE_REG),
};
static struct regmap_access_table hmc5843_writable_table = {
- .yes_ranges = hmc5843_writable_ranges,
- .n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges),
+ .yes_ranges = hmc5843_writable_ranges,
+ .n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges),
};
static const struct regmap_range hmc5843_volatile_ranges[] = {
- regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG),
+ regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG),
};
static struct regmap_access_table hmc5843_volatile_table = {
- .yes_ranges = hmc5843_volatile_ranges,
- .n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges),
+ .yes_ranges = hmc5843_volatile_ranges,
+ .n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges),
};
static struct regmap_config hmc5843_i2c_regmap_config = {
- .reg_bits = 8,
- .val_bits = 8,
+ .reg_bits = 8,
+ .val_bits = 8,
- .rd_table = &hmc5843_readable_table,
- .wr_table = &hmc5843_writable_table,
- .volatile_table = &hmc5843_volatile_table,
+ .rd_table = &hmc5843_readable_table,
+ .wr_table = &hmc5843_writable_table,
+ .volatile_table = &hmc5843_volatile_table,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_RBTREE,
};
static int hmc5843_i2c_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
return hmc5843_common_probe(&client->dev,
- devm_regmap_init_i2c(client, &hmc5843_i2c_regmap_config),
- id->driver_data);
+ devm_regmap_init_i2c(client, &hmc5843_i2c_regmap_config),
+ id->driver_data);
}
static int hmc5843_i2c_remove(struct i2c_client *client)
--
2.3.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] Staging: iio: Coding Style Correction
2015-02-08 8:04 [PATCH 1/1] Staging: iio: Coding Style Correction Tolga Ceylan
@ 2015-02-08 11:52 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2015-02-08 11:52 UTC (permalink / raw)
To: Tolga Ceylan, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Greg Kroah-Hartman, Josef Gajdusek, linux-iio, devel,
linux-kernel
On 08/02/15 08:04, Tolga Ceylan wrote:
> Indentation corrections in struct initializations and
> one line over 80 characters split into two lines
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
Whilst I find it hard to be inspired by these sort of patches,
you have presented the patch well and it's entirely sensible.
Only slight niggle that I've fixed is your patch title doesn't mention
the driver in question (and hence is identical to the other patch you
submitted at a quick glance).
Anyhow, applied to the togreg branch of iio.git which will get
pushed out as testing sometime soonish - perhaps controlled by when
my plane actually shows up today....
> ---
> drivers/staging/iio/magnetometer/hmc5843_i2c.c | 34 +++++++++++++-------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_i2c.c b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> index 6acd614..e221a58 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> @@ -19,49 +19,49 @@
> #include "hmc5843.h"
>
> static const struct regmap_range hmc5843_readable_ranges[] = {
> - regmap_reg_range(0, HMC5843_ID_END),
> + regmap_reg_range(0, HMC5843_ID_END),
> };
>
> static struct regmap_access_table hmc5843_readable_table = {
> - .yes_ranges = hmc5843_readable_ranges,
> - .n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges),
> + .yes_ranges = hmc5843_readable_ranges,
> + .n_yes_ranges = ARRAY_SIZE(hmc5843_readable_ranges),
> };
>
> static const struct regmap_range hmc5843_writable_ranges[] = {
> - regmap_reg_range(0, HMC5843_MODE_REG),
> + regmap_reg_range(0, HMC5843_MODE_REG),
> };
>
> static struct regmap_access_table hmc5843_writable_table = {
> - .yes_ranges = hmc5843_writable_ranges,
> - .n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges),
> + .yes_ranges = hmc5843_writable_ranges,
> + .n_yes_ranges = ARRAY_SIZE(hmc5843_writable_ranges),
> };
>
> static const struct regmap_range hmc5843_volatile_ranges[] = {
> - regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG),
> + regmap_reg_range(HMC5843_DATA_OUT_MSB_REGS, HMC5843_STATUS_REG),
> };
>
> static struct regmap_access_table hmc5843_volatile_table = {
> - .yes_ranges = hmc5843_volatile_ranges,
> - .n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges),
> + .yes_ranges = hmc5843_volatile_ranges,
> + .n_yes_ranges = ARRAY_SIZE(hmc5843_volatile_ranges),
> };
>
> static struct regmap_config hmc5843_i2c_regmap_config = {
> - .reg_bits = 8,
> - .val_bits = 8,
> + .reg_bits = 8,
> + .val_bits = 8,
>
> - .rd_table = &hmc5843_readable_table,
> - .wr_table = &hmc5843_writable_table,
> - .volatile_table = &hmc5843_volatile_table,
> + .rd_table = &hmc5843_readable_table,
> + .wr_table = &hmc5843_writable_table,
> + .volatile_table = &hmc5843_volatile_table,
>
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_RBTREE,
> };
>
> static int hmc5843_i2c_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> return hmc5843_common_probe(&client->dev,
> - devm_regmap_init_i2c(client, &hmc5843_i2c_regmap_config),
> - id->driver_data);
> + devm_regmap_init_i2c(client, &hmc5843_i2c_regmap_config),
> + id->driver_data);
> }
>
> static int hmc5843_i2c_remove(struct i2c_client *client)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-08 11:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 7:40 [PATCH 1/1] Staging: iio: Coding style correction Tolga Ceylan
2015-02-08 11:55 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2015-02-08 8:04 [PATCH 1/1] Staging: iio: Coding Style Correction Tolga Ceylan
2015-02-08 11:52 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox