* [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string
@ 2015-01-27 21:32 Rickard Strandqvist
2015-02-08 11:59 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-27 21:32 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack
Cc: Rickard Strandqvist, Lars-Peter Clausen, Peter Meerwald,
Greg Kroah-Hartman, Joel Porquet, Darshana Padmadas,
Catalina Mocanu, Wolfram Sang, linux-iio, devel, linux-kernel
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
index a24caf7..66d54a0 100644
--- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
+++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
@@ -52,7 +52,7 @@ static ssize_t iio_trig_periodic_read_freq(struct device *dev,
struct iio_trigger *trig = to_iio_trigger(dev);
struct iio_prtc_trigger_info *trig_info = iio_trigger_get_drvdata(trig);
- return sprintf(buf, "%u\n", trig_info->frequency);
+ return sprintf(buf, "%d\n", trig_info->frequency);
}
static ssize_t iio_trig_periodic_write_freq(struct device *dev,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string
2015-01-27 21:32 [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string Rickard Strandqvist
@ 2015-02-08 11:59 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-02-08 11:59 UTC (permalink / raw)
To: Rickard Strandqvist, Hartmut Knaack
Cc: Lars-Peter Clausen, Peter Meerwald, Greg Kroah-Hartman,
Joel Porquet, Darshana Padmadas, Catalina Mocanu, Wolfram Sang,
linux-iio, devel, linux-kernel
On 27/01/15 21:32, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'unsigned int'
> but the argument type is 'int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Whilst you have identified a bug, I think the better fix would be to take frequency unsigned.
It is always treated as such in the driver so they type should probably reflect this.
If you want to put together such a patch that would be great. If not I'll
get to it at some point (probably!)
> ---
> drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> index a24caf7..66d54a0 100644
> --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> @@ -52,7 +52,7 @@ static ssize_t iio_trig_periodic_read_freq(struct device *dev,
> struct iio_trigger *trig = to_iio_trigger(dev);
> struct iio_prtc_trigger_info *trig_info = iio_trigger_get_drvdata(trig);
>
> - return sprintf(buf, "%u\n", trig_info->frequency);
> + return sprintf(buf, "%d\n", trig_info->frequency);
> }
>
> static ssize_t iio_trig_periodic_write_freq(struct device *dev,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-08 12:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 21:32 [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string Rickard Strandqvist
2015-02-08 11:59 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox