* [PATCH] staging: iio: impedance-analyzer: ad5933: Change type in printf format string
@ 2015-01-27 22:18 Rickard Strandqvist
2015-02-08 12:01 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-27 22:18 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich
Cc: Rickard Strandqvist, Jonathan Cameron, Hartmut Knaack,
Peter Meerwald, Greg Kroah-Hartman, linux-iio, devel,
linux-kernel
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index b6bd609..4230a43 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
mutex_lock(&indio_dev->mlock);
switch ((u32) this_attr->address) {
case AD5933_OUT_RANGE:
- len = sprintf(buf, "%d\n",
+ len = sprintf(buf, "%u\n",
st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
break;
case AD5933_OUT_RANGE_AVAIL:
- len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
+ len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
st->range_avail[3], st->range_avail[2],
st->range_avail[1]);
break;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: iio: impedance-analyzer: ad5933: Change type in printf format string
2015-01-27 22:18 [PATCH] staging: iio: impedance-analyzer: ad5933: Change type in printf format string Rickard Strandqvist
@ 2015-02-08 12:01 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-02-08 12:01 UTC (permalink / raw)
To: Rickard Strandqvist, Lars-Peter Clausen, Michael Hennerich
Cc: Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On 27/01/15 22:18, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Sorry, you were beaten to this one by Asaf Vertz a few weeks back.
Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index b6bd609..4230a43 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
> mutex_lock(&indio_dev->mlock);
> switch ((u32) this_attr->address) {
> case AD5933_OUT_RANGE:
> - len = sprintf(buf, "%d\n",
> + len = sprintf(buf, "%u\n",
> st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
> break;
> case AD5933_OUT_RANGE_AVAIL:
> - len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
> + len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
> st->range_avail[3], st->range_avail[2],
> st->range_avail[1]);
> break;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-08 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 22:18 [PATCH] staging: iio: impedance-analyzer: ad5933: Change type in printf format string Rickard Strandqvist
2015-02-08 12:01 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox