From: Jonathan Cameron <jic23@kernel.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Baluta <daniel.baluta@intel.com>,
Roberta Dobrescu <roberta.dobrescu@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Mario Schuknecht <mario.schuknecht@dresearch-fe.de>,
Aybuke Ozdemir <aybuke.147@gmail.com>,
Tina Johnson <tinajohnson.1234@gmail.com>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string
Date: Sun, 08 Feb 2015 12:03:42 +0000 [thread overview]
Message-ID: <54D7509E.8030105@kernel.org> (raw)
In-Reply-To: <1422397204-9079-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 27/01/15 22:20, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Another one with a fix already in place.
> ---
> drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index 423f96b..4a5dc26 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1147,7 +1147,7 @@ static ssize_t tsl2x7x_luxtable_show(struct device *dev,
> int offset = 0;
>
> while (i < (TSL2X7X_MAX_LUX_TABLE_SIZE * 3)) {
> - offset += snprintf(buf + offset, PAGE_SIZE, "%d,%d,%d,",
> + offset += snprintf(buf + offset, PAGE_SIZE, "%u,%u,%u,",
> chip->tsl2x7x_device_lux[i].ratio,
> chip->tsl2x7x_device_lux[i].ch0,
> chip->tsl2x7x_device_lux[i].ch1);
>
prev parent reply other threads:[~2015-02-08 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 22:20 [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string Rickard Strandqvist
2015-02-08 12:03 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D7509E.8030105@kernel.org \
--to=jic23@kernel.org \
--cc=aybuke.147@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.schuknecht@dresearch-fe.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pmeerw@pmeerw.net \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=roberta.dobrescu@gmail.com \
--cc=tinajohnson.1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox