From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757069AbbBHMDs (ORCPT ); Sun, 8 Feb 2015 07:03:48 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:39237 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756683AbbBHMDq (ORCPT ); Sun, 8 Feb 2015 07:03:46 -0500 Message-ID: <54D7509E.8030105@kernel.org> Date: Sun, 08 Feb 2015 12:03:42 +0000 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rickard Strandqvist , Hartmut Knaack CC: Lars-Peter Clausen , Peter Meerwald , Greg Kroah-Hartman , Daniel Baluta , Roberta Dobrescu , "Paul E. McKenney" , Mario Schuknecht , Aybuke Ozdemir , Tina Johnson , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string References: <1422397204-9079-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1422397204-9079-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/01/15 22:20, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'int' > but the argument type is 'unsigned int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Another one with a fix already in place. > --- > drivers/staging/iio/light/tsl2x7x_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c > index 423f96b..4a5dc26 100644 > --- a/drivers/staging/iio/light/tsl2x7x_core.c > +++ b/drivers/staging/iio/light/tsl2x7x_core.c > @@ -1147,7 +1147,7 @@ static ssize_t tsl2x7x_luxtable_show(struct device *dev, > int offset = 0; > > while (i < (TSL2X7X_MAX_LUX_TABLE_SIZE * 3)) { > - offset += snprintf(buf + offset, PAGE_SIZE, "%d,%d,%d,", > + offset += snprintf(buf + offset, PAGE_SIZE, "%u,%u,%u,", > chip->tsl2x7x_device_lux[i].ratio, > chip->tsl2x7x_device_lux[i].ch0, > chip->tsl2x7x_device_lux[i].ch1); >