* [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string
@ 2015-01-27 22:20 Rickard Strandqvist
2015-02-08 12:03 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-27 22:20 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack
Cc: Rickard Strandqvist, Lars-Peter Clausen, Peter Meerwald,
Greg Kroah-Hartman, Daniel Baluta, Roberta Dobrescu,
Paul E. McKenney, Mario Schuknecht, Aybuke Ozdemir, Tina Johnson,
linux-iio, devel, linux-kernel
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
index 423f96b..4a5dc26 100644
--- a/drivers/staging/iio/light/tsl2x7x_core.c
+++ b/drivers/staging/iio/light/tsl2x7x_core.c
@@ -1147,7 +1147,7 @@ static ssize_t tsl2x7x_luxtable_show(struct device *dev,
int offset = 0;
while (i < (TSL2X7X_MAX_LUX_TABLE_SIZE * 3)) {
- offset += snprintf(buf + offset, PAGE_SIZE, "%d,%d,%d,",
+ offset += snprintf(buf + offset, PAGE_SIZE, "%u,%u,%u,",
chip->tsl2x7x_device_lux[i].ratio,
chip->tsl2x7x_device_lux[i].ch0,
chip->tsl2x7x_device_lux[i].ch1);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string
2015-01-27 22:20 [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string Rickard Strandqvist
@ 2015-02-08 12:03 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-02-08 12:03 UTC (permalink / raw)
To: Rickard Strandqvist, Hartmut Knaack
Cc: Lars-Peter Clausen, Peter Meerwald, Greg Kroah-Hartman,
Daniel Baluta, Roberta Dobrescu, Paul E. McKenney,
Mario Schuknecht, Aybuke Ozdemir, Tina Johnson, linux-iio, devel,
linux-kernel
On 27/01/15 22:20, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Another one with a fix already in place.
> ---
> drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index 423f96b..4a5dc26 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1147,7 +1147,7 @@ static ssize_t tsl2x7x_luxtable_show(struct device *dev,
> int offset = 0;
>
> while (i < (TSL2X7X_MAX_LUX_TABLE_SIZE * 3)) {
> - offset += snprintf(buf + offset, PAGE_SIZE, "%d,%d,%d,",
> + offset += snprintf(buf + offset, PAGE_SIZE, "%u,%u,%u,",
> chip->tsl2x7x_device_lux[i].ratio,
> chip->tsl2x7x_device_lux[i].ch0,
> chip->tsl2x7x_device_lux[i].ch1);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-08 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 22:20 [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string Rickard Strandqvist
2015-02-08 12:03 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox