* [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string
@ 2015-01-27 22:21 Rickard Strandqvist
2015-02-08 12:04 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-27 22:21 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack
Cc: Rickard Strandqvist, Lars-Peter Clausen, Peter Meerwald,
Greg Kroah-Hartman, Josef Gajdusek, Teodora Baluta, Marek Belisko,
linux-iio, devel, linux-kernel
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/iio/magnetometer/hmc5843_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c
index fd171d8..cd049bb 100644
--- a/drivers/staging/iio/magnetometer/hmc5843_core.c
+++ b/drivers/staging/iio/magnetometer/hmc5843_core.c
@@ -217,7 +217,7 @@ static ssize_t hmc5843_show_measurement_configuration(struct device *dev,
return ret;
val &= HMC5843_MEAS_CONF_MASK;
- return sprintf(buf, "%d\n", val);
+ return sprintf(buf, "%u\n", val);
}
static ssize_t hmc5843_set_measurement_configuration(struct device *dev,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string
2015-01-27 22:21 [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string Rickard Strandqvist
@ 2015-02-08 12:04 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-02-08 12:04 UTC (permalink / raw)
To: Rickard Strandqvist, Hartmut Knaack
Cc: Lars-Peter Clausen, Peter Meerwald, Greg Kroah-Hartman,
Josef Gajdusek, Teodora Baluta, Marek Belisko, linux-iio, devel,
linux-kernel
On 27/01/15 22:21, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
This one is fixed to I'm afraid. Very bad luck on timing as 2 weeks ago you'd have
been first to post a patch for it.
> ---
> drivers/staging/iio/magnetometer/hmc5843_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c
> index fd171d8..cd049bb 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_core.c
> @@ -217,7 +217,7 @@ static ssize_t hmc5843_show_measurement_configuration(struct device *dev,
> return ret;
> val &= HMC5843_MEAS_CONF_MASK;
>
> - return sprintf(buf, "%d\n", val);
> + return sprintf(buf, "%u\n", val);
> }
>
> static ssize_t hmc5843_set_measurement_configuration(struct device *dev,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-08 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 22:21 [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string Rickard Strandqvist
2015-02-08 12:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox