From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758340AbbBHMEl (ORCPT ); Sun, 8 Feb 2015 07:04:41 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:39244 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756189AbbBHMEi (ORCPT ); Sun, 8 Feb 2015 07:04:38 -0500 Message-ID: <54D750D2.9080601@kernel.org> Date: Sun, 08 Feb 2015 12:04:34 +0000 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rickard Strandqvist , Hartmut Knaack CC: Lars-Peter Clausen , Peter Meerwald , Greg Kroah-Hartman , Josef Gajdusek , Teodora Baluta , Marek Belisko , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string References: <1422397297-9206-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1422397297-9206-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/01/15 22:21, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'int' > but the argument type is 'unsigned int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist This one is fixed to I'm afraid. Very bad luck on timing as 2 weeks ago you'd have been first to post a patch for it. > --- > drivers/staging/iio/magnetometer/hmc5843_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c > index fd171d8..cd049bb 100644 > --- a/drivers/staging/iio/magnetometer/hmc5843_core.c > +++ b/drivers/staging/iio/magnetometer/hmc5843_core.c > @@ -217,7 +217,7 @@ static ssize_t hmc5843_show_measurement_configuration(struct device *dev, > return ret; > val &= HMC5843_MEAS_CONF_MASK; > > - return sprintf(buf, "%d\n", val); > + return sprintf(buf, "%u\n", val); > } > > static ssize_t hmc5843_set_measurement_configuration(struct device *dev, >