* [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string
@ 2015-01-27 22:22 Rickard Strandqvist
2015-02-08 12:06 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-27 22:22 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich
Cc: Rickard Strandqvist, Jonathan Cameron, Hartmut Knaack,
Peter Meerwald, Greg Kroah-Hartman, linux-iio, devel,
linux-kernel
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/iio/resolver/ad2s1210.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
index b4c14ba..a8ecf87 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -198,7 +198,7 @@ static ssize_t ad2s1210_show_fclkin(struct device *dev,
{
struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
- return sprintf(buf, "%d\n", st->fclkin);
+ return sprintf(buf, "%u\n", st->fclkin);
}
static ssize_t ad2s1210_store_fclkin(struct device *dev,
@@ -237,7 +237,7 @@ static ssize_t ad2s1210_show_fexcit(struct device *dev,
{
struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
- return sprintf(buf, "%d\n", st->fexcit);
+ return sprintf(buf, "%u\n", st->fexcit);
}
static ssize_t ad2s1210_store_fexcit(struct device *dev,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string
2015-01-27 22:22 [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string Rickard Strandqvist
@ 2015-02-08 12:06 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-02-08 12:06 UTC (permalink / raw)
To: Rickard Strandqvist, Lars-Peter Clausen, Michael Hennerich
Cc: Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On 27/01/15 22:22, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Finally one I don't already have a fix in place for!
Applied to the togreg branch of iio.git.
Note this will first get pushed out as staging when I get a few minutes at
home (no sign of my plane yet that was meant to leave an hour ago...)
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index b4c14ba..a8ecf87 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -198,7 +198,7 @@ static ssize_t ad2s1210_show_fclkin(struct device *dev,
> {
> struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
>
> - return sprintf(buf, "%d\n", st->fclkin);
> + return sprintf(buf, "%u\n", st->fclkin);
> }
>
> static ssize_t ad2s1210_store_fclkin(struct device *dev,
> @@ -237,7 +237,7 @@ static ssize_t ad2s1210_show_fexcit(struct device *dev,
> {
> struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev));
>
> - return sprintf(buf, "%d\n", st->fexcit);
> + return sprintf(buf, "%u\n", st->fexcit);
> }
>
> static ssize_t ad2s1210_store_fexcit(struct device *dev,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-08 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 22:22 [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string Rickard Strandqvist
2015-02-08 12:06 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox