From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760641AbbBIJtW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Feb 2015 04:49:22 -0500
Received: from eusmtp01.atmel.com ([212.144.249.242]:23032 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759960AbbBIJtU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Feb 2015 04:49:20 -0500
Message-ID: <54D88290.6030501@atmel.com>
Date: Mon, 9 Feb 2015 17:49:04 +0800
From: Josh Wu <josh.wu@atmel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Boris Brezillon <boris.brezillon@free-electrons.com>
CC: Nicolas Ferre <nicolas.ferre@atmel.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        "Ian Campbell" <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        Andrew Victor <linux@maxim.org.za>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: at91: dts: sama5d4: add dts for sama5d4 xplained
 board
References: <1423473423-17798-1-git-send-email-josh.wu@atmel.com> <20150209102435.56f39b81@bbrezillon>
In-Reply-To: <20150209102435.56f39b81@bbrezillon>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.168.5.13]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Boris

On 2/9/2015 5:24 PM, Boris Brezillon wrote:
> Hi Josh,
>
> On Mon, 9 Feb 2015 17:17:03 +0800
> Josh Wu <josh.wu@atmel.com> wrote:
>
>> Add at91 sama5d4 xplained board support.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>> ---
>>
>> Changes in v2:
>> - to be sorted by memory address, put the adc dt node after usart4.
>>
>>   arch/arm/boot/dts/Makefile                  |   1 +
>>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 232 ++++++++++++++++++++++++++++
>>   2 files changed, 233 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/at91-sama5d4_xplained.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 91bd5bd..bbfbad6 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_AT91)	+= sama5d34ek.dtb
>>   dtb-$(CONFIG_ARCH_AT91)	+= sama5d35ek.dtb
>>   dtb-$(CONFIG_ARCH_AT91)	+= sama5d36ek.dtb
>>   # sama5d4
>> +dtb-$(CONFIG_ARCH_AT91)	+= at91-sama5d4_xplained.dtb
>>   dtb-$(CONFIG_ARCH_AT91)	+= at91-sama5d4ek.dtb
>>   
>>   dtb-$(CONFIG_ARCH_ATLAS6) += atlas6-evb.dtb
>> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
>> new file mode 100644
>> index 0000000..a04c3c8
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
>> @@ -0,0 +1,232 @@
>> +/*
>> + * at91-sama5d4_xplained.dts - Device Tree file for SAMA5D4 Xplained board
>> + *
>> + *  Copyright (C) 2015 Atmel,
>> + *                2015 Josh Wu <josh.wu@atmel.com>
>> + *
> [...]
>
>> +	ahb {
>> +		apb {
>> +			spi0: spi@f8010000 {
>> +				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
>> +				status = "okay";
>> +				m25p80@0 {
>> +					compatible = "atmel,at25df321a";
>> +					spi-max-frequency = <50000000>;
>> +					reg = <0>;
>> +				};
>> +			};
>> +
>> +			macb0: ethernet@f8020000 {
>> +				phy-mode = "rmii";
>> +				status = "okay";
> Could you define the PHY device attached to this ethernet MAC IP ?
>
>
>                                  ethernet-phy@1 {
>                                          reg = <0x1>;
>                                          /*
> 					 * interrupt-parent = <&pioB>;
> 					 * interrupts = <25
> 					 *	   IRQ_TYPE_EDGE_FALLING>;
> 					 */
> 					/* ... */
> 				};
Ok, I will add this in next version. Thanks.

Best Regards,
Josh Wu

>
>
> Best Regards,
>
> Boris
>