From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933877AbbBITod (ORCPT ); Mon, 9 Feb 2015 14:44:33 -0500 Received: from mail-la0-f53.google.com ([209.85.215.53]:39173 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbbBITob (ORCPT ); Mon, 9 Feb 2015 14:44:31 -0500 Message-ID: <54D90E1A.4090406@gmail.com> Date: Mon, 09 Feb 2015 20:44:26 +0100 From: Xavier Naveira User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Darren Hart CC: Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thinkpad_acpi: unhandled hkey event References: <1422730323-14473-1-git-send-email-xnaveira@gmail.com> <20150207042244.GD20934@fury.dvhart.com> In-Reply-To: <20150207042244.GD20934@fury.dvhart.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-02-07 05:22, Darren Hart wrote: > On Sat, Jan 31, 2015 at 07:52:03PM +0100, Xavier Naveira wrote: >> Pressing Fn+Esc in a Lenovo Thinkpad x240 to lock the Fn keys generates >> an unhandled hkey event >> >> Signed-off-by: Xavier Naveira >> --- >> drivers/platform/x86/thinkpad_acpi.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c >> index c3d11fa..e61c43b 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -196,6 +196,7 @@ enum tpacpi_hkey_event_t { >> /* Key-related user-interface events */ >> TP_HKEY_EV_KEY_NUMLOCK = 0x6000, /* NumLock key pressed */ >> TP_HKEY_EV_KEY_FN = 0x6005, /* Fn key pressed? E420 */ >> + TP_HKEY_EV_KEY_FN_ESC = 0x6060, /* Fn+Esc key pressed X240 */ >> >> /* Thermal events */ >> TP_HKEY_EV_ALARM_BAT_HOT = 0x6011, /* battery too hot */ >> @@ -3717,6 +3718,12 @@ static bool hotkey_notify_6xxx(const u32 hkey, >> *send_acpi_ev = false; >> *ignore_acpi_ev = true; >> return true; >> + case TP_HKEY_EV_KEY_FN_ESC: >> + /* key press events, we just ignore them as long as the EC >> + * is still reporting them in the normal keyboard stream */ >> + *send_acpi_ev = false; >> + *ignore_acpi_ev = true; >> + return true; > > No need to duplicate the logic here, just add TP_HKEY_EV_KEY_FN_ESC to the list > of fallthrough keys (right after TP_HKEY_EV_KEY_FN). > I don't see the list that you are referring to?