public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Gilad Avidov <gavidov@codeaurora.org>,
	sdharia@codeaurora.org, mlocke@codeaurora.org,
	linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, iivanov@mm-sol.com,
	galak@codeaurora.org, agross@codeaurora.org
Subject: Re: [PATCH V3 0/2] add support for pmic_arb v2 and correct framework
Date: Mon, 09 Feb 2015 15:08:58 -0800	[thread overview]
Message-ID: <54D93E0A.9000703@codeaurora.org> (raw)
In-Reply-To: <1423522272-24472-1-git-send-email-gavidov@codeaurora.org>

On 02/09/15 14:51, Gilad Avidov wrote:
> pmic_arb v2 has no support for spmi non-data commands and thus
> returns -EOPNOTSUPP on .cmd callback. This causes a failure in
> spmi_drv_probe() which sends a wakeup command to the slave before
> probing its driver. This patchset removes the wakeup from
> spmi_drv_probe() since the spmi spec stipulates that a slaves
> default state is active and doesn't need a wakeup.

The spec also seems to stipulate that SPMI masters shall support all
SPMI command sequences.

> Gilad Avidov (2):
>   spmi: remove wakeup command before slave probe
>   spmi: pmic_arb: add support for hw version 2
>
>  .../bindings/spmi/qcom,spmi-pmic-arb.txt           |   6 +-
>  drivers/spmi/spmi-pmic-arb.c                       | 312 +++++++++++++++++----
>  drivers/spmi/spmi.c                                |   9 +-
>  3 files changed, 263 insertions(+), 64 deletions(-)
>

Can you please include a patchset changelog here? What changed between
v2 and v3?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2015-02-09 23:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 22:51 [PATCH V3 0/2] add support for pmic_arb v2 and correct framework Gilad Avidov
2015-02-09 22:51 ` [PATCH V3 1/2] spmi: remove wakeup command before slave probe Gilad Avidov
2015-02-18 15:39   ` Josh Cartwright
2015-02-18 19:17     ` Stephen Boyd
2015-02-19 19:23       ` Gilad Avidov
2015-02-09 22:51 ` [PATCH V3 2/2] spmi: pmic_arb: add support for hw version 2 Gilad Avidov
2015-02-18 15:34   ` Josh Cartwright
2015-02-19 17:29     ` Gilad Avidov
2015-02-09 23:08 ` Stephen Boyd [this message]
2015-02-11 18:05   ` [PATCH V3 0/2] add support for pmic_arb v2 and correct framework Gilad Avidov
2015-02-12  0:53     ` Stephen Boyd
2015-02-13 19:50   ` Gilad Avidov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D93E0A.9000703@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=gavidov@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iivanov@mm-sol.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlocke@codeaurora.org \
    --cc=sdharia@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox