public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
	linux-kernel@vger.kernel.org,
	xen-devel <xen-devel@lists.xenproject.org>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"David Vrabel" <david.vrabel@citrix.com>
Subject: Re: [GIT PULL] (xen) for-jens-3.20 for v3.20 Xen blk driver updates
Date: Tue, 10 Feb 2015 08:27:35 -0700	[thread overview]
Message-ID: <54DA2367.8020200@fb.com> (raw)
In-Reply-To: <54DA0083.4010503@citrix.com>

On 02/10/2015 05:58 AM, Roger Pau Monné wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello Jens,
>
> There are 3 fixes for Xen blk drivers. One adds myself as a maintainer
> (together with Konrad). There's also one to improve compatibility with
> older xen-blkfront versions that did not specify a protocol version.
> The remaining one is a fix for blkfront to correctly account the
> number of requests on the queue when resuming from suspension.
>
> Thanks, Roger.
>
> The following changes since commit
> e36f014edff70fc02b3d3d79cead1d58f289332e:
>
>    Linux 3.19-rc7 (2015-02-01 20:07:21 -0800)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-jens-3.20

This is based on 3.19-rc7, which means that when I pulled it into 
for-3.20/drivers, I get a ton of unrelated commits as well. That's no 
good. The pull request should be based on for-3.20/drivers or earlier. 
So please rebase the three patches on top of for-3.20/drivers. Konrad 
does the right thing here. Not sure if you are going to be sending pull 
requests going forward (or both of you), but it might not hurt to sync 
up with Konrad and ensure you guys are on the same page.

Secondly, this is a bit late. But since it's just two fixes (not 
features) and a maintainer update, it's not a huge deal. It's a bit 
annoying though since every pull request like this will push my pull 
request by a day or two, so generally I prefer to have pull requests at 
least the week before the merge window opens.

-- 
Jens Axboe


  reply	other threads:[~2015-02-10 15:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 12:58 [GIT PULL] (xen) for-jens-3.20 for v3.20 Xen blk driver updates Roger Pau Monné
2015-02-10 15:27 ` Jens Axboe [this message]
2015-02-10 16:10   ` David Vrabel
2015-02-10 16:12     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DA2367.8020200@fb.com \
    --to=axboe@fb.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox