From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406AbbBKKu2 (ORCPT ); Wed, 11 Feb 2015 05:50:28 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:14746 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbbBKKu0 (ORCPT ); Wed, 11 Feb 2015 05:50:26 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-40-54db335d1520 Message-id: <54DB33EE.9020609@samsung.com> Date: Wed, 11 Feb 2015 11:50:22 +0100 From: Robert Baldyga User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: Vinod Koul Cc: dan.j.williams@intel.com, lars@metafoo.de, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, k.kozlowski@samsung.com, kyungmin.park@samsung.com, l.czerwinski@samsung.com, padma.kvr@gmail.com Subject: Re: [PATCH v3 1/2] dma: pl330: improve pl330_tx_status() function References: <1418208918-28127-1-git-send-email-r.baldyga@samsung.com> <1418208918-28127-2-git-send-email-r.baldyga@samsung.com> <20150211002318.GB21387@intel.com> In-reply-to: <20150211002318.GB21387@intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t/xK7qxxrdDDM5/ZbaYPvUCo8XqqX9Z LV6/MLQ42/SG3eLXtElsFksmz2e1uLxrDpvF2iN32S3al81htXjZt5/Fgctj56y77B6L97xk 8ljy5hCrR9+WVYwenzfJBbBGcdmkpOZklqUW6dslcGVMOrOLueCEcMX3O4vZGhh/83cxcnJI CJhI7Ho8gQXCFpO4cG89WxcjF4eQwFJGiR8XQRIgzkdGib5Nq4EcDg5eAS2JhuXJIA0sAqoS P7q/MYLYbAI6Elu+TwCzRQUiJOYfe80MYvMKCEr8mHwPbIEIUP2Wnx2MIDOZBV4ySny7/I4N JCEs4CVx++JkVohlyxgluj/MZgJJcAroS/TdfM8KsphZQE/i/kUtkDCzgLzE5jVvmScwCsxC smMWQtUsJFULGJlXMYqmliYXFCel5xrpFSfmFpfmpesl5+duYoREwNcdjEuPWR1iFOBgVOLh tYi5FSLEmlhWXJl7iFGCg1lJhDdC7HaIEG9KYmVValF+fFFpTmrxIUYmDk6pBsaWYzdat6dG Vb48ZeVn7Kims8vbxnNn9vfN+zf/8HB6N/0wh98l58TN7G3Tzk9VZ3Xe3u/pnLHpyVXeYH6p Im9f1S9v3iuyGP8TnVP29uP21ANp8zNv9zxmDfDfzxJ3+cNK877e5aGXaqMrjKpEX19a3GK8 0+m3wSUe3p4Zz1lfnasrM/mRl6bEUpyRaKjFXFScCACyjK8tXgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2015 01:23 AM, Vinod Koul wrote: > On Wed, Dec 10, 2014 at 11:55:17AM +0100, Robert Baldyga wrote: >> This patch adds possibility to read residue of DMA transfer. It's useful >> when we want to know how many bytes have been transferred before we >> terminate channel. It can take place, for example, on timeout interrupt. >> >> Signed-off-by: Lukasz Czerwinski >> Signed-off-by: Robert Baldyga >> --- >> drivers/dma/pl330.c | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 66 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c >> index bdf40b5..2f4d561 100644 >> --- a/drivers/dma/pl330.c >> +++ b/drivers/dma/pl330.c >> @@ -504,6 +504,9 @@ struct dma_pl330_desc { >> >> enum desc_status status; >> >> + int bytes_requested; >> + bool last; >> + >> /* The channel which currently holds this desc */ >> struct dma_pl330_chan *pchan; >> >> @@ -2182,11 +2185,68 @@ static void pl330_free_chan_resources(struct dma_chan *chan) >> pm_runtime_put_autosuspend(pch->dmac->ddma.dev); >> } >> >> +int pl330_get_current_xferred_count(struct dma_pl330_chan *pch, >> + struct dma_pl330_desc *desc) >> +{ >> + struct pl330_thread *thrd = pch->thread; >> + struct pl330_dmac *pl330 = pch->dmac; >> + void __iomem *regs = thrd->dmac->base; >> + u32 val, addr; >> + >> + pm_runtime_get_sync(pl330->ddma.dev); >> + val = addr = 0; >> + if (desc->rqcfg.src_inc) { >> + val = readl(regs + SA(thrd->id)); >> + addr = desc->px.src_addr; >> + } else { >> + val = readl(regs + DA(thrd->id)); >> + addr = desc->px.dst_addr; >> + } >> + pm_runtime_mark_last_busy(pch->dmac->ddma.dev); >> + pm_runtime_put_autosuspend(pl330->ddma.dev); >> + return val - addr; >> +} >> + >> static enum dma_status >> pl330_tx_status(struct dma_chan *chan, dma_cookie_t cookie, >> struct dma_tx_state *txstate) >> { >> - return dma_cookie_status(chan, cookie, txstate); >> + enum dma_status ret; >> + unsigned long flags; >> + struct dma_pl330_desc *desc, *running = NULL; >> + struct dma_pl330_chan *pch = to_pchan(chan); >> + unsigned int transferred, residual = 0; >> + >> + spin_lock_irqsave(&pch->lock, flags); > You want to check the dma_cookie_status here first and then based on status > go into residue calcaultion, that too only when the txstate is NON null. > Ok, I will send v4. Thanks, Robert Baldyga