[PATCH 0/3] Expose more controls from tegra-max98090

[PATCH 0/3] Expose more controls from tegra-max98090

[Tomeu Vizoso]

Hello,

we need some more controls in userspace so policy can be applied at events
such as microphone and headphone jacks being plugged in, to be used by
Tegra-based Chromebooks.

Regards,

Tomeu

Tomeu Vizoso (3):
  ASoC: tegra: Expose Headphones pin to userspace
  ASoC: tegra: Add sink for the internal mic to tegra_max98090
  ASoC: tegra: Add control for the Mic Jack pin

 .../devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt         | 1 +
 sound/soc/tegra/tegra_max98090.c                                      | 4 ++++
 2 files changed, 5 insertions(+)

-- 
1.9.3

[PATCH 1/3] ASoC: tegra: Expose Headphones pin to userspace

[Tomeu Vizoso]

So userspace can enable or disable it based on the current policy.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 sound/soc/tegra/tegra_max98090.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/tegra/tegra_max98090.c b/sound/soc/tegra/tegra_max98090.c
index af3fb99..8df71a4 100644
--- a/sound/soc/tegra/tegra_max98090.c
+++ b/sound/soc/tegra/tegra_max98090.c
@@ -136,6 +136,7 @@ static const struct snd_soc_dapm_widget tegra_max98090_dapm_widgets[] = {
 };
 
 static const struct snd_kcontrol_new tegra_max98090_controls[] = {
+	SOC_DAPM_PIN_SWITCH("Headphones"),
 	SOC_DAPM_PIN_SWITCH("Speakers"),
 };
 
-- 
1.9.3

[PATCH 2/3] ASoC: tegra: Add sink for the internal mic to tegra_max98090

[Tomeu Vizoso]

Also adds a control for the pin of the internal mic, so userspace can
apply policy when the state of the external mic jack changes.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt | 1 +
 sound/soc/tegra/tegra_max98090.c                                        | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt
index c949abc..c3495be 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt
@@ -18,6 +18,7 @@ Required properties:
   * Headphones
   * Speakers
   * Mic Jack
+  * Int Mic
 
 - nvidia,i2s-controller : The phandle of the Tegra I2S controller that's
   connected to the CODEC.
diff --git a/sound/soc/tegra/tegra_max98090.c b/sound/soc/tegra/tegra_max98090.c
index 8df71a4..29ea87c 100644
--- a/sound/soc/tegra/tegra_max98090.c
+++ b/sound/soc/tegra/tegra_max98090.c
@@ -133,11 +133,13 @@ static const struct snd_soc_dapm_widget tegra_max98090_dapm_widgets[] = {
 	SND_SOC_DAPM_HP("Headphones", NULL),
 	SND_SOC_DAPM_SPK("Speakers", NULL),
 	SND_SOC_DAPM_MIC("Mic Jack", NULL),
+	SND_SOC_DAPM_MIC("Int Mic", NULL),
 };
 
 static const struct snd_kcontrol_new tegra_max98090_controls[] = {
 	SOC_DAPM_PIN_SWITCH("Headphones"),
 	SOC_DAPM_PIN_SWITCH("Speakers"),
+	SOC_DAPM_PIN_SWITCH("Int Mic"),
 };
 
 static int tegra_max98090_asoc_init(struct snd_soc_pcm_runtime *rtd)
-- 
1.9.3

[PATCH 3/3] ASoC: tegra: Add control for the Mic Jack pin

[Tomeu Vizoso]

So userspace can enable and disable the external microphone.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 sound/soc/tegra/tegra_max98090.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/tegra/tegra_max98090.c b/sound/soc/tegra/tegra_max98090.c
index 29ea87c..1f20c2c 100644
--- a/sound/soc/tegra/tegra_max98090.c
+++ b/sound/soc/tegra/tegra_max98090.c
@@ -139,6 +139,7 @@ static const struct snd_soc_dapm_widget tegra_max98090_dapm_widgets[] = {
 static const struct snd_kcontrol_new tegra_max98090_controls[] = {
 	SOC_DAPM_PIN_SWITCH("Headphones"),
 	SOC_DAPM_PIN_SWITCH("Speakers"),
+	SOC_DAPM_PIN_SWITCH("Mic Jack"),
 	SOC_DAPM_PIN_SWITCH("Int Mic"),
 };
 
-- 
1.9.3

Re: [PATCH 0/3] Expose more controls from tegra-max98090

[Stephen Warren]

On 02/11/2015 07:49 AM, Tomeu Vizoso wrote:
> Hello,
>
> we need some more controls in userspace so policy can be applied at events
> such as microphone and headphone jacks being plugged in, to be used by
> Tegra-based Chromebooks.

The series,
Acked-by: Stephen Warren <swarren@nvidia.com>

Re: [PATCH 0/3] Expose more controls from tegra-max98090

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Wed, Feb 11, 2015 at 03:49:51PM +0100, Tomeu Vizoso wrote:
> Hello,
> 
> we need some more controls in userspace so policy can be applied at events
> such as microphone and headphone jacks being plugged in, to be used by
> Tegra-based Chromebooks.

I see that your "v2" which only added an ack was sent less than a day
after this initial posting.  Don't do that, it just adds to the mail
volume.  Only resend if it's been a while and there's been no review or
if you've got an actual change to make otherwise the mail isn't really
adding anything.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]