From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] block: handle the null_mapped flag correctly in blk_rq_map_user_iov
Date: Wed, 11 Feb 2015 11:23:06 -0700 [thread overview]
Message-ID: <54DB9E0A.7090009@fb.com> (raw)
In-Reply-To: <1423660070-24652-2-git-send-email-hch@lst.de>
On 02/11/2015 06:07 AM, Christoph Hellwig wrote:
> The tape drivers (and the sg driver in a special case that doesn't matter
> here) use the null_mapped flag to tell blk_rq_map_user to not copy around
> any data into or out of the bounce buffers. blk_rq_map_user_iov never
> got that treatment, which didn't matter until I refactored blk_rq_map_user
> to be implemented in terms of blk_rq_map_user_iov.
So this fixes a regression caused by:
commit ddad8dd0a162fde61646a627a3017c258601dc8a
Author: Christoph Hellwig <hch@lst.de>
Date: Sun Jan 18 16:16:29 2015 +0100
block: use blk_rq_map_user_iov to implement blk_rq_map_user
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
which we should probably note in the commit. I'll add that.
--
Jens Axboe
next prev parent reply other threads:[~2015-02-11 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 13:07 two simple block patches Christoph Hellwig
2015-02-11 13:07 ` [PATCH 1/2] block: handle the null_mapped flag correctly in blk_rq_map_user_iov Christoph Hellwig
2015-02-11 18:23 ` Jens Axboe [this message]
2015-02-11 13:07 ` [PATCH 2/2] block: remove unused function blk_bio_map_sg Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB9E0A.7090009@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox