Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

Mathias Nyman
2015-02-16T09:25:32Z

On 15.02.2015 16:29, Sneeker Yeh wrote:
> hi Mathias:
>
> thanks for reviewing these patch,
> and sorry for replying lately~
>

>>> + status = readl(port_array[dev_port_num - 1]);
>>> +
>>> + /* write 1 to clear */
>>> + if (!(status & PORT_CONNECT) && (status & PORT_CSC))
>>> + writel(status & PORT_CSC, port_array[0]);
>>
>> Shouldn't this be writel(...,port_array[dev_port_num - 1]) ?
>
> yes, thanks for correcting this,
> and I also would like to add xhci_port_state_to_neutral() you mentioned.
> what would you think if I modify it like this?
>
> + /* write 1 to clear */
> + if (!(status & PORT_CONNECT) && (status & PORT_CSC)) {
> + status = xhci_port_state_to_neutral(status);
> + writel(status | PORT_CSC, port_array[dev_port_num - 1]);
> + }
>

Looks good to me

-Mathias