From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752675AbbBLXCy (ORCPT ); Thu, 12 Feb 2015 18:02:54 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:5911 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbbBLXCw (ORCPT ); Thu, 12 Feb 2015 18:02:52 -0500 Message-ID: <54DD3113.8000903@fb.com> Date: Thu, 12 Feb 2015 16:02:43 -0700 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Linus Torvalds CC: Tejun Heo , Ronny Hegewald , Dan Williams , Linux Kernel Mailing List Subject: Re: [GIT PULL] Block driver changes for 3.20 References: <20150212205752.GC24835@kernel.dk> <54DD2E47.7060601@fb.com> <54DD3017.7030909@fb.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.57.29] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-02-12_07:2015-02-12,2015-02-12,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 kscore.is_bulkscore=0 kscore.compositescore=0 circleOfTrustscore=28.8701424542426 compositescore=0.939076664828693 urlsuspect_oldscore=0.939076664828693 suspectscore=0 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=62764 rbsscore=0.939076664828693 spamscore=0 recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1502120228 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2015 04:01 PM, Linus Torvalds wrote: > On Thu, Feb 12, 2015 at 2:58 PM, Jens Axboe wrote: >> >> commit 9269e23496ddd83b974536019cf420520df0ee7f >> Author: Shaohua Li >> Date: Fri Jan 23 20:17:59 2015 -0800 >> >> libata: make sata_sil24 use fifo tag allocator >> >> libata starts using block tag now, we can use BLK_TAG_ALLOC_FIFO to >> solve the sata_sil24 tag bug. > > Ahh, ok. So we should probably just remove the now unused/useless > ATA_FLAG_LOWTAG entirely. Yeah, we can kill that after the fact. I probably should have pulled in that commit from Dan and fixed this up... But in any case, it'll be fine as is right now. -- Jens Axboe