From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445AbbBMFdN (ORCPT ); Fri, 13 Feb 2015 00:33:13 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52701 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbbBMFdM (ORCPT ); Fri, 13 Feb 2015 00:33:12 -0500 Message-ID: <54DD8C92.7050201@suse.com> Date: Fri, 13 Feb 2015 06:33:06 +0100 From: Juergen Gross User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com CC: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com, mmarek@suse.cz, linux-kbuild@vger.kernel.org Subject: Re: [RESEND Patch V2 1/4] xen: build infrastructure for generating hypercall depending symbols References: <1421826565-10826-1-git-send-email-jgross@suse.com> <1421826565-10826-2-git-send-email-jgross@suse.com> In-Reply-To: <1421826565-10826-2-git-send-email-jgross@suse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ###### ### # # ##### # # # ## # # # # # # # # # # ###### # # # # # #### # # # # # # # # # # ## # # # ### # # ##### David still wants a comment from the x86 maintainers... Juergen On 01/21/2015 08:49 AM, Juergen Gross wrote: > Today there are several places in the kernel which build tables > containing one entry for each possible Xen hypercall. Create an > infrastructure to be able to generate these tables at build time. > > Based-on-patch-by: Jan Beulich > Signed-off-by: Juergen Gross > Reviewed-by: David Vrabel > --- > arch/x86/syscalls/Makefile | 9 +++++++++ > scripts/xen-hypercalls.sh | 12 ++++++++++++ > 2 files changed, 21 insertions(+) > create mode 100644 scripts/xen-hypercalls.sh > > diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile > index 3323c27..a55abb9 100644 > --- a/arch/x86/syscalls/Makefile > +++ b/arch/x86/syscalls/Makefile > @@ -19,6 +19,9 @@ quiet_cmd_syshdr = SYSHDR $@ > quiet_cmd_systbl = SYSTBL $@ > cmd_systbl = $(CONFIG_SHELL) '$(systbl)' $< $@ > > +quiet_cmd_hypercalls = HYPERCALLS $@ > + cmd_hypercalls = $(CONFIG_SHELL) '$<' $@ $(filter-out $<,$^) > + > syshdr_abi_unistd_32 := i386 > $(uapi)/unistd_32.h: $(syscall32) $(syshdr) > $(call if_changed,syshdr) > @@ -47,10 +50,16 @@ $(out)/syscalls_32.h: $(syscall32) $(systbl) > $(out)/syscalls_64.h: $(syscall64) $(systbl) > $(call if_changed,systbl) > > +$(out)/xen-hypercalls.h: $(srctree)/scripts/xen-hypercalls.sh > + $(call if_changed,hypercalls) > + > +$(out)/xen-hypercalls.h: $(srctree)/include/xen/interface/xen*.h > + > uapisyshdr-y += unistd_32.h unistd_64.h unistd_x32.h > syshdr-y += syscalls_32.h > syshdr-$(CONFIG_X86_64) += unistd_32_ia32.h unistd_64_x32.h > syshdr-$(CONFIG_X86_64) += syscalls_64.h > +syshdr-$(CONFIG_XEN) += xen-hypercalls.h > > targets += $(uapisyshdr-y) $(syshdr-y) > > diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh > new file mode 100644 > index 0000000..676d922 > --- /dev/null > +++ b/scripts/xen-hypercalls.sh > @@ -0,0 +1,12 @@ > +#!/bin/sh > +out="$1" > +shift > +in="$@" > + > +for i in $in; do > + eval $CPP $LINUXINCLUDE -dD -imacros "$i" -x c /dev/null > +done | \ > +awk '$1 == "#define" && $2 ~ /__HYPERVISOR_[a-z][a-z_0-9]*/ { v[$3] = $2 } > + END { print "/* auto-generated by scripts/xen-hypercall.sh */" > + for (i in v) if (!(v[i] in v)) > + print "HYPERCALL("substr(v[i], 14)")"}' | sort -u >$out >