From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbbBMHSy (ORCPT ); Fri, 13 Feb 2015 02:18:54 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:42372 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbbBMHSw (ORCPT ); Fri, 13 Feb 2015 02:18:52 -0500 Message-ID: <54DDA55A.9090600@gmail.com> Date: Thu, 12 Feb 2015 23:18:50 -0800 From: tolga ceylan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joe Perches CC: Dan Carpenter , Lidza Louina , Mark Hounschell , Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements References: <1423645712-10645-1-git-send-email-tolga.ceylan@gmail.com> <20150211103613.GM5206@mwanda> <1423808441.2795.1.camel@perches.com> In-Reply-To: <1423808441.2795.1.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2015 10:20 PM, Joe Perches wrote: > On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote: >> On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter wrote: >>> That looks kind of uglier than before. Please run your patch throught >>> scripts/checkpatch.pl --strict. > [] >> Running with --strict helped, but now I'm also getting warnings for >> camel case usage. > > You can use --strict --ignore=camelcase > >> If I try to fix camel case, then >> the patch will get much larger spanning many dgnc_* files. I can >> proceed with this if you think it is valuable/acceptable. > > I suggest not. > > Just noticed this warning in all dgnc_* files: * NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! * * This is shared code between Digi's CVS archive and the * Linux Kernel sources. * Changing the source just for reformatting needlessly breaks * our CVS diff history. * * Send any bug fixes/changes to: Eng.Linux at digi dot com. * Thank you. Seems unusual. Also get_maintainers.pl does not return any digi dot com addresses.