public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Yi Li <yilikernel@sina.cn>, <yili@gzhdi.com>,
	<linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>
Cc: <jinsong.liu@intel.com>, Yi Li <yilikernel@gmail.com>,
	<david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen: fix mcelog/stub depend issue in Kconfig
Date: Fri, 13 Feb 2015 16:50:19 +0000	[thread overview]
Message-ID: <54DE2B4B.6020709@citrix.com> (raw)
In-Reply-To: <1423845146-6669-1-git-send-email-yilikernel@sina.cn>

On 13/02/15 16:32, Yi Li wrote:
> 
> From: Yi Li <yilikernel@gmail.com>
> 
> Fix support mcelog/stub in Kconfig for Xen X86 platform

Is this actually sufficient?  I'm fairly sure the Xen MCE driver does
not correctly handle the 64-bit ABI that Xen provides and there would
need to be some compat translations done.

> Signed-off-by: Yi Li <yilikernel@gmail.com>
> ---
>  drivers/xen/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index b812462..83ae68a 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -188,7 +188,7 @@ config XEN_PRIVCMD
>  
>  config XEN_STUB
>  	bool "Xen stub drivers"
> -	depends on XEN && X86_64 && BROKEN
> +	depends on XEN && X86 && BROKEN
>  	default n
>  	help
>  	  Allow kernel to install stub drivers, to reserve space for Xen drivers,
> @@ -240,7 +240,7 @@ config XEN_ACPI_PROCESSOR
>  
>  config XEN_MCE_LOG
>  	bool "Xen platform mcelog"
> -	depends on XEN_DOM0 && X86_64 && X86_MCE
> +	depends on XEN_DOM0 && X86 && X86_MCE
>  	default n
>  	help
>  	  Allow kernel fetching MCE error from Xen platform and
> 


      reply	other threads:[~2015-02-13 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 16:32 [PATCH] xen: fix mcelog/stub depend issue in Kconfig Yi Li
2015-02-13 16:50 ` David Vrabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DE2B4B.6020709@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=jinsong.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yili@gzhdi.com \
    --cc=yilikernel@gmail.com \
    --cc=yilikernel@sina.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox