public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Tunin <hanipouspilot@gmail.com>
To: alex.ploumistos@gmail.com, marcel@holtmann.org,
	gustavo@padovan.org, johan.hedberg@gmail.com
Cc: jwboyer@redhat.com, linux-bluetooth@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Alexander Ploumistos <alexpl@fedoraproject.org>
Subject: Re: [PATCH] Bluetooth: ath3k: Add support for 04f2:aff1 (Atheros AR5B195 combo Mini PCIe card)
Date: Fri, 13 Feb 2015 21:50:55 +0300	[thread overview]
Message-ID: <54DE478F.5090501@gmail.com> (raw)
In-Reply-To: <1423852422-20972-1-git-send-email-alexpl@fedoraproject.org>

> From: alxpl <alex.ploumistos@gmail.com>
> 
> 
> With a lot of help and pointers from Dmitry Tunin, I managed to put the patch together in the "appropriate" fashion, against bluetooth-next. He also suggested that I include the relevant information from my /sys/kernel/debug/usb/devices. If it is still sub-par, please let me know what needs to be fixed. I also came across a thread in the Arch forum and it would seem that someone has already patched ath3k and btusb for the exact same device:
> https://bbs.archlinux.org/viewtopic.php?id=126487
> 
> So here is everything:
> 
> T:  Bus=05 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  2 Spd=12   MxCh= 0
> D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=04f2 ProdID=aff1 Rev= 0.01
> C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=1ms
> E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
> I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
> I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
> I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
> I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
> E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms
> 
> 
> Signed-off-by: Alexander Ploumistos <alexpl@fedoraproject.org>
> ---
>  drivers/bluetooth/ath3k.c | 1 +
>  drivers/bluetooth/btusb.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index de4c849..288547a 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -65,6 +65,7 @@ static const struct usb_device_id ath3k_table[] = {
>  	/* Atheros AR3011 with sflash firmware*/
>  	{ USB_DEVICE(0x0489, 0xE027) },
>  	{ USB_DEVICE(0x0489, 0xE03D) },
> +	{ USB_DEVICE(0x04F2, 0xAFF1) },
>  	{ USB_DEVICE(0x0930, 0x0215) },
>  	{ USB_DEVICE(0x0CF3, 0x3002) },
>  	{ USB_DEVICE(0x0CF3, 0xE019) },
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index b876888..2f9c9d8c 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -159,6 +159,7 @@ static const struct usb_device_id blacklist_table[] = {
>  	/* Atheros 3011 with sflash firmware */
>  	{ USB_DEVICE(0x0489, 0xe027), .driver_info = BTUSB_IGNORE },
>  	{ USB_DEVICE(0x0489, 0xe03d), .driver_info = BTUSB_IGNORE },
> +	{ USB_DEVICE(0x04f2, 0xaff1), .driver_info = BTUSB_IGNORE },
>  	{ USB_DEVICE(0x0930, 0x0215), .driver_info = BTUSB_IGNORE },
>  	{ USB_DEVICE(0x0cf3, 0x3002), .driver_info = BTUSB_IGNORE },
>  	{ USB_DEVICE(0x0cf3, 0xe019), .driver_info = BTUSB_IGNORE },
> 

Alex,

1. Replace commit text regarding my help with something relevant.
2. Make [PATCH v2] so Marcel can commit it.

Regards,

Dmitry

  reply	other threads:[~2015-02-13 18:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 15:54 [PATCH] Add support for Atheros AR5B195 combo Mini PCIe cards (AR3011 Bluetooth) Alexander Ploumistos
2015-02-12 19:36 ` Marcel Holtmann
2015-02-12 23:31   ` Alexander Ploumistos
2015-02-13 18:33 ` [PATCH] Bluetooth: ath3k: Add support for 04f2:aff1 (Atheros AR5B195 combo Mini PCIe card) alex.ploumistos
2015-02-13 18:50   ` Dmitry Tunin [this message]
2015-02-13 19:05 ` [PATCH v2] " alex.ploumistos
2015-02-13 19:20   ` Dmitry Tunin
2015-02-13 19:21     ` Josh Boyer
2015-02-13 19:37       ` Alexander Ploumistos
2015-02-13 19:41         ` Josh Boyer
2015-02-14 23:48   ` Marcel Holtmann
2015-02-15  0:43     ` Alexander Ploumistos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DE478F.5090501@gmail.com \
    --to=hanipouspilot@gmail.com \
    --cc=alex.ploumistos@gmail.com \
    --cc=alexpl@fedoraproject.org \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=jwboyer@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox