Re: [PATCH 5/7] perf list: avoid confusion of perf output and the next command prompt

Yunlong Song
2015-02-15T10:03:20Z

On 2015/2/13 22:52, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 13, 2015 at 09:11:53PM +0800, Yunlong Song escreveu:
>> Distinguish the output of 'perf list --list-opts' or 'perf --list-cmds'
>> with the next command prompt, which also happens in other cases (e.g.
>> record, report ...).
>>
>> Example
>> Before this patch:
>> $perf list --list-opts
>> --raw-dump $ <-- the output and the next command prompt are at
>> the same line
>>
>> After this patch:
>> $perf list --list-opts
>> --raw-dump
>> $ <-- the new line
>
> Unsure about this one, IIRC this --list-opts thing was added to be used
> together with shell autocompletion, have you checked that this extra
> newline is OK with that?
>
> Please try searching for the changeset that introduced --list-opts to
> get info about how to test this,
>
> Thanks,
>
> - Arnaldo
>
> .
>

Already checked, it's really OK.

--
Thanks,
Yunlong Song