The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Luis de Bethencourt <luis@debethencourt.com>,
	linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: Recent commit introduces compiler Error in some platforms
Date: Mon, 16 Feb 2015 13:36:43 +0100	[thread overview]
Message-ID: <54E1E45B.2040602@xs4all.nl> (raw)
In-Reply-To: <20150216121829.GA23673@biggie>

On 02/16/2015 01:18 PM, Luis de Bethencourt wrote:
> Hi all,
> 
> As can be seen in Han's build log:
> http://hverkuil.home.xs4all.nl/logs/Saturday.log
> 
> The recent commit bc0c5aa35ac88342831933ca7758ead62d9bae2b introduces a
> compiler error in some platforms.
> 
> /home/hans/work/build/media_build/v4l/ir-hix5hd2.c: In function 'hix5hd2_ir_config':
> /home/hans/work/build/media_build/v4l/ir-hix5hd2.c:95:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
>   writel_relaxed(0x01, priv->base + IR_ENABLE);
>   ^
> 
> Better than reverting, what would be a good solution for this problem?
> I am happy to implment it once I know what is the right direction.
> 
> From what I see that commit mentions that the function is now available from
> include/asm-generic/io.h, but this isn't included.

I've just fixed the media_build repository to handle this. Do a git pull and
it should compile again (only tested against kernel 3.18).

Regards,

	Hans

> Thanks,
> Luis
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2015-02-16 12:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 12:18 Recent commit introduces compiler Error in some platforms Luis de Bethencourt
2015-02-16 12:36 ` Hans Verkuil [this message]
2015-02-16 12:49   ` Luis de Bethencourt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E1E45B.2040602@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=luis@debethencourt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox