From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751604AbbBPX6v (ORCPT ); Mon, 16 Feb 2015 18:58:51 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:35030 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbbBPX6t (ORCPT ); Mon, 16 Feb 2015 18:58:49 -0500 X-AuditID: cbfee68d-f79296d000004278-60-54e284376125 Message-id: <54E28437.3080105@samsung.com> Date: Tue, 17 Feb 2015 08:58:47 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Charles Keepax Cc: cw00.choi@samsung.com, Chanwoo Choi , "myungjoo.ham@samsung.com" , Samuel Ortiz , Lee Jones , Liam Girdwood , Mark Brown , patches@opensource.wolfsonmicro.com, linux-kernel Subject: Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic References: <1424101263-27593-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-reply-to: Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkWNe85VGIwc1p1hZTHz5hs/g35Qa7 xfUvz1ktnh3Vtrj/9SijxbcrHUwWl3fNYbO43biCzWL52/9sFqe7WR24PHbOusvusWlVJ5vH nWt72DzmnQz0eDnxN5tH35ZVjB6fN8kFsEdx2aSk5mSWpRbp2yVwZWxas5y14Bd7xZs7jUwN jGvZuhg5OSQETCReXG1khbDFJC7cWw8U5+IQEljKKPHrwydGmKJTmxoYIRLTGSXm9b2DqnrN KPHo9DwmkCpeAS2JnlmvwGwWAVWJNycXgnWzAcX3v7gBtk5UIExi5fQrLBD1ghI/Jt8Ds0UE LCSmLLnFDDKUWeAuk8SO++vYQRLCAr4SP5buA7tPSGAOo8T+qb4gNqdAsMSX5qlgy5gF1CUm zVvEDGHLS2xe8xZskITAW3aJfSd+sEBcJCDxbfIhIJsDKCErsekAM8RrkhIHV9xgmcAoNgvJ TbOQjJ2FZOwCRuZVjKKpBckFxUnpRYZ6xYm5xaV56XrJ+bmbGIFxevrfs94djLcPWB9iFOBg VOLh/aDyMESINbGsuDL3EKMp0BUTmaVEk/OBySCvJN7Q2MzIwtTE1NjI3NJMSZxXUepnsJBA emJJanZqakFqUXxRaU5q8SFGJg5OqQZGSYmyhbvbE3M4arzitrQZihp0qFlMWNDx8ZnFqs4A oftPTpkmL1Cp63dImq3YdOSYt1TnmZU9u4ImVNsbnl3PnfH/Lcup3ECmPufHNtqsEk59T9Zd Vqt2X9vB6fC0Sq0kOOPnA+fD3mX3VKW/SsedyXihYfzyZppLKVtfmN1z59VM1xVLvZRYijMS DbWYi4oTAcOp6anOAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42I5/e+xoK55y6MQg0VbjC2mPnzCZvFvyg12 i+tfnrNaPDuqbXH/61FGi29XOpgsLu+aw2Zxu3EFm8Xyt//ZLE53szpweeycdZfdY9OqTjaP O9f2sHnMOxno8XLibzaPvi2rGD0+b5ILYI9qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUz MNQ1tLQwV1LIS8xNtVVy8QnQdcvMAbpOSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBc j5EBGkhYw5ixac1y1oJf7BVv7jQyNTCuZeti5OSQEDCROLWpgRHCFpO4cG89UJyLQ0hgOqPE vL53UM5rRolHp+cxgVTxCmhJ9Mx6BWazCKhKvDm5EKybDSi+/8UNsKmiAmESK6dfYYGoF5T4 MfkemC0iYCExZcktZpChzAJ3mSR23F/HDpIQFvCV+LF0HyuILSQwh1Fi/1RfEJtTIFjiS/NU sGXMAuoSk+YtYoaw5SU2r3nLPIFRYBaSHbOQlM1CUraAkXkVo2hqQXJBcVJ6rpFecWJucWle ul5yfu4mRnASeCa9g3FVg8UhRgEORiUe3g8qD0OEWBPLiitzDzFKcDArifC+ynsUIsSbklhZ lVqUH19UmpNafIjRFBgEE5mlRJPzgQkqryTe0NjEzMjSyNzQwsjYXEmcV8m+LURIID2xJDU7 NbUgtQimj4mDU6qB0emWBVfmP629nhOiGP6sdr/hLCEa3/tiRY7v9hwn/Tz5v1Uyyl1lZseU p8WXSU3itZsZqb8llo2jT/LP9c1zuIQ2rJ38tIs1ucZ63TmhC29U1ihuUnf70GO/yTC+YtWT PfI6qnqnONWED3VmuR/Oqzkkwv6x67tMrfbCU/VlohWbWLWill1TYinOSDTUYi4qTgQAWRfB ZBgDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Charles, On 02/17/2015 01:48 AM, Chanwoo Choi wrote: > Hi Charles, > > > On Tue, Feb 17, 2015 at 12:41 AM, Charles Keepax > wrote: >> arizona_extcon_do_magic does not lend a lot of clarity to the purpose >> of the function, and as all the registers used are described in the >> datasheet there is no need to obfuscate the code. This patch renames the >> function to arizona_extcon_hp_clamp, as it controls clamping on the >> headphone output. >> >> Signed-off-by: Charles Keepax >> --- >> drivers/extcon/extcon-arizona.c | 36 ++++++++++++++++++++---------------- >> include/linux/mfd/arizona/core.h | 2 +- >> sound/soc/codecs/arizona.c | 4 ++-- >> 3 files changed, 23 insertions(+), 19 deletions(-) > > > Looks good to me. > But, you need more ack message by MFD maintainer. > > For extcon part: > Acked-by: Chanwoo Choi Applied it. Thanks, Chanwoo Choi