From: Peter Hung <hpeter@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V6 03/10] USB: f81232: implement RX bulk-in ep
Date: Tue, 17 Feb 2015 09:41:56 +0800 [thread overview]
Message-ID: <54E29C64.2090704@gmail.com> (raw)
In-Reply-To: <20150216194115.GB9296@kroah.com>
Hello,
Greg KH 於 2015/2/17 上午 03:41 寫道:
>> + if (unlikely(data[i+0] & UART_LSR_BRK_ERROR_BITS)) {
>
> Never use unlikely() unless you can prove that it actually matters if
> you use it. Hint, it's almost impossible to prove, so don't use it, the
> compiler and processor look-ahead is almost smarter than we are.
Thanks for your hint. I'll remove it with next patch.
--
With Best Regards,
Peter Hung
next prev parent reply other threads:[~2015-02-17 1:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 7:57 [PATCH V6 00/10] USB: f81232: V6 patches Peter Hung
2015-02-16 7:57 ` [PATCH V6 01/10] USB: f81232: rename private struct member name Peter Hung
2015-02-16 7:57 ` [PATCH V6 02/10] USB: f81232: implement read IIR/MSR with endpoint Peter Hung
2015-02-17 8:30 ` Johan Hovold
2015-02-16 7:57 ` [PATCH V6 03/10] USB: f81232: implement RX bulk-in ep Peter Hung
2015-02-16 19:41 ` Greg KH
2015-02-17 1:41 ` Peter Hung [this message]
2015-02-17 10:06 ` David Laight
2015-02-17 14:48 ` 'Greg KH'
2015-02-16 7:57 ` [PATCH V6 04/10] USB: f81232: implement set_termios Peter Hung
2015-02-17 8:59 ` Johan Hovold
2015-02-16 7:57 ` [PATCH V6 05/10] USB: f81232: implement MCR/MSR function Peter Hung
2015-02-17 9:40 ` Johan Hovold
2015-02-16 7:57 ` [PATCH V6 06/10] USB: f81232: clarify f81232_ioctl and fix Peter Hung
2015-02-16 7:57 ` [PATCH V6 07/10] USB: f81232: fix error in f81232_carrier_raised() Peter Hung
2015-02-17 9:44 ` Johan Hovold
2015-02-16 7:58 ` [PATCH V6 08/10] USB: f81232: fix read MSR strange value Peter Hung
2015-02-17 9:51 ` Johan Hovold
2015-02-24 2:17 ` Peter Hung
2015-02-16 7:58 ` [PATCH V6 09/10] USB: f81232: implement delta change for MSR count Peter Hung
2015-02-16 7:58 ` [PATCH V6 10/10] USB: f81232: modify/add author Peter Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E29C64.2090704@gmail.com \
--to=hpeter@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox