From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757146AbbBQLfz (ORCPT ); Tue, 17 Feb 2015 06:35:55 -0500 Received: from mail-la0-f47.google.com ([209.85.215.47]:37663 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757069AbbBQLfY (ORCPT ); Tue, 17 Feb 2015 06:35:24 -0500 Message-ID: <54E32778.3060307@cogentembedded.com> Date: Tue, 17 Feb 2015 14:35:20 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Florian Fainelli , linux-mips@linux-mips.org CC: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, mpm@selenic.com, herbert@gondor.apana.org.au, wsa@the-dreams.de, cernekee@gmail.com Subject: Re: [PATCH 2/4] hw_random: bcm63xx-rng: move register definitions to driver References: <1424138956-11563-1-git-send-email-f.fainelli@gmail.com> <1424138956-11563-3-git-send-email-f.fainelli@gmail.com> In-Reply-To: <1424138956-11563-3-git-send-email-f.fainelli@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 2/17/2015 5:09 AM, Florian Fainelli wrote: > arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h contains the register > definitions for this random number generator block, incorporate these > register definitions directly into the bcm63xx-rng driver so we do not > rely on this header to be provided. > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/bcm63xx-rng.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c > index ed9b28b35a39..c7f3af852599 100644 > --- a/drivers/char/hw_random/bcm63xx-rng.c > +++ b/drivers/char/hw_random/bcm63xx-rng.c > @@ -13,7 +13,15 @@ > #include > #include > > -#include > +#define RNG_CTRL 0x00 > +#define RNG_EN (1 << 0) > + > +#define RNG_STAT 0x04 > +#define RNG_AVAIL_MASK (0xff000000) Parens not needed here. WBR, Sergei