From: Hans Verkuil <hverkuil@xs4all.nl>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Antti Palosaari <crope@iki.fi>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls
Date: Tue, 17 Feb 2015 13:23:33 +0100 [thread overview]
Message-ID: <54E332C5.6080503@xs4all.nl> (raw)
In-Reply-To: <CAPybu_3EJo0imtPoM3WJbjn2nNjf=D3WnJmmdpLQ3_qzo5oXvA@mail.gmail.com>
On 02/17/15 13:21, Ricardo Ribalda Delgado wrote:
> Hello Hans
>
> On Tue, Feb 17, 2015 at 1:03 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> Should be done after the 'ctrl == NULL' check.
>
> Good catch. Fixed on v2
>
>>
>>>
>>> if (ctrl == NULL)
>>> continue;
>>>
>>
>> There is one more change that has to be made: setting a volatile control
>> should never generate a V4L2_EVENT_CTRL_CH_VALUE event since that makes
>> no sense. The way to prevent that is to ensure that ctrl->has_changed is
>> always false for volatile controls. The new_to_cur function looks at that
>> field to decide whether to send an event.
>>
>> The documentation should also be updated: that of V4L2_CTRL_FLAG_VOLATILE
>> (in VIDIOC_QUERYCTRL), and of V4L2_EVENT_CTRL_CH_VALUE.
>
> I can do this also if you want. It has been a while without
> contributing to media :)
Yes, please. I can't accept the patch without these other changes anyway :-)
Regards,
Hans
prev parent reply other threads:[~2015-02-17 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 11:02 [PATCH] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls Ricardo Ribalda Delgado
2015-02-17 11:17 ` Hans Verkuil
2015-02-17 11:29 ` Ricardo Ribalda Delgado
2015-02-17 11:32 ` Sakari Ailus
2015-02-17 13:53 ` Jacek Anaszewski
2015-02-17 14:06 ` Sakari Ailus
2015-02-17 14:22 ` Jacek Anaszewski
2015-02-17 14:35 ` Sakari Ailus
2015-02-17 15:14 ` Jacek Anaszewski
2015-02-17 12:03 ` Hans Verkuil
2015-02-17 12:21 ` Ricardo Ribalda Delgado
2015-02-17 12:23 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E332C5.6080503@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=ricardo.ribalda@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox