From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933261AbbBQOQC (ORCPT ); Tue, 17 Feb 2015 09:16:02 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:55356 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933242AbbBQOQA (ORCPT ); Tue, 17 Feb 2015 09:16:00 -0500 Message-ID: <54E34D14.8080901@ti.com> Date: Tue, 17 Feb 2015 16:15:48 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Robert Abel CC: , Tony Lindgren , , , Linux Kernel Maling List Subject: Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children References: <1424101741-24152-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-2-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-4-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-5-git-send-email-rabel@cit-ec.uni-bielefeld.de> <54E30CD6.6020905@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/15 15:57, Robert Abel wrote: > Hi Roger, > > On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros wrote:> >> Can we simply use only >> of_platform_populate(child, NULL, NULL, &pdev->dev) >> >> That way we get rid of the if..else and let OF core take care of >> creating buses or devices. > > Surely, you mean > >> of_platform_populate(child, of_default_bus_match_table, NULL, &pdev->dev); > > ? If matches is NULL, we won't match any busses. Or did you mean to > just replace the second conditional? I was wondering if just one call to of_platform_populate() is sufficient. so you probably need "of_default_bus_match_table" for matches. > > I'll try that and see it works. > cheers, -roger